Item9260: Allow the INTERWIKIPLUGIN_RULESTOPIC to be a comma separated list

Priority: Enhancement
Current State: Closed
Released In: 1.1.3
Target Release: patch
Applies To: Extension
Component: InterwikiPlugin
Reported By: JoenioCosta
Waiting For:
Last Change By: KennethLavrsen
-- JoenioCosta - 04 Jul 2010

Hi Joenio, thank you for the patch, and with unit tests too - perfect! We are in feature freeze until Foswiki 1.1 is branched from trunk, but I am sure we would love to see this in the next Foswiki version.

Just a quick note: the reason nobody has given feedback on this task (probably) is because you set it "WaitingFor" nobody.

When we quickly scan the tasks list, most of us assume that a WaitingFor status means it is being taken care of somebody already.

I would like to invite you to RequestAccessToSubversion so that you may checkin this nice new feature yourself.

Set back to 'new' (if you checkin this feature, please set this WaitingForRelease so it can be included in the release notes for the next Foswiki version)

-- PaulHarvey - 09 Jul 2010

At the moment, it is possible to set up aliases in the Main web by setting the following:

   * #Set INTERWIKIPLUGIN_RULESTOPIC = %MAINWEB%.InterWikis

However, this overwrites the rules topic, so you would have to copy the rules from System.InterWikis for them to still work.

What your patch does is allow Main.InterWikis to inherit from System.InterWikis and define new rules or overwrite rules. This is a great idea, but will need to go through our feature proposal process so it can be discussed.

Personally, I think the best solution would be for the INTERWIKIPLUGIN_RULESTOPIC to become a comma separated list to allow a hierarchy of rules topics, like this:

   * #Set INTERWIKIPLUGIN_RULESTOPIC = %SYSTEMWEB%.InterWikis, %MAINWEB%.InterWikis

-- AndrewJones - 12 Jul 2010

Turns out there already is a similar feature proposal at InheritWikiLinksTopics

-- AndrewJones - 12 Jul 2010

Also, I have committed your unit tests to prove that the INTERWIKIPLUGIN_RULESTOPIC is being set correctly. Bit surprised this plugin did not have any unit tests before now.

-- AndrewJones - 12 Jul 2010

I agree with the solution proposed by AndrewJones about INTERWIKIPLUGIN_RULESTOPIC to become a comma separated list of rules topics. I will take a look at this.

Thanks for all the feedback!

-- JoenioCosta - 12 Jul 2010

I made a new feature proposal so this may get implemented in 1.2, if approved.

-- AndrewJones - 12 Jul 2010

Done, will be in 1.1.3 smile

-- AndrewJones - 10 Dec 2010

Changed the Set statements in this topic to #Set comments so they don't break the Tasks application.

-- GeorgeClark - 20 Dec 2010
 

ItemTemplate edit

Summary Allow the INTERWIKIPLUGIN_RULESTOPIC to be a comma separated list
ReportedBy JoenioCosta
Codebase trunk
SVN Range
AppliesTo Extension
Component InterwikiPlugin
Priority Enhancement
CurrentState Closed
WaitingFor
Checkins distro:6802a9387fe2 distro:3602b1945507 distro:09311c49fa81 distro:5d0edb40dfad distro:577e846e5e1d distro:c1feff06c0df
TargetRelease patch
ReleasedIn 1.1.3

I Attachment Action Size Date Who Comment
Now_is_possible_to_edit_aliases_in_Main_Web.diffdiff Now_is_possible_to_edit_aliases_in_Main_Web.diff manage 5.2 K 04 Jul 2010 - 15:25 JoenioCosta Patch with the new proposed feature and some unit tests
Topic revision: r19 - 16 Apr 2011, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License