You are here: Foswiki>Tasks Web>Item11600 (11 Apr 2012, GeorgeClark)Edit Attach

Item11600: Hitting cancel on the 'edit topic preferences' oopsmore UI saves the changes

Priority: Urgent
Current State: Closed
Released In: 1.1.5
Target Release: patch
Applies To: Engine
Branches: Release01x01 trunk
Reported By: SvenDowideit
Waiting For:
Last Change By: GeorgeClark
see r26 of Tasks.Item10659

which means that a series of GET requests can modify a topic. thus invalidating (or worse) the cache, and, oh, the sky is falling.

(ok, so I hope we can get this done for 1.1.5 smile

-- SvenDowideit - 05 Mar 2012

Actually, it does a POST and saves the changes. So no GET involved. Cancel does not appear to be implemented in the code (or documented).

The form appears to have two options (undocumented)
  • action_save=Save Set when Save is pressed
  • action_cancel=Cancel Set when Cancel is pressed.

Neither option is examined in the code.

For 1.1.5, will change code to implement action_cancel. This really should be redesigned to not post to saveSettings.

-- GeorgeClark - 05 Mar 2012

Breaks NatEditPlugin. See Item11625.

-- MichaelDaum - 08 Mar 2012

ItemTemplate edit

Summary Hitting cancel on the 'edit topic preferences' oopsmore UI saves the changes
ReportedBy SvenDowideit
Codebase 1.1.4, 1.1.3, 1.1.2, 1.1.1, 1.1.0, 1.0.10, 1.0.9, trunk
SVN Range
AppliesTo Engine
Priority Urgent
CurrentState Closed
Checkins distro:95d13f2d7d5b distro:90848197d9fb distro:5bf75a24b650 distro:911f9f1a8946
TargetRelease patch
ReleasedIn 1.1.5
CheckinsOnBranches Release01x01 trunk
trunkCheckins distro:5bf75a24b650 distro:911f9f1a8946
Release01x01Checkins distro:95d13f2d7d5b distro:90848197d9fb
Topic revision: r10 - 11 Apr 2012, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy