Foswiki on GitHub is open for business! Next release meeting: Monday Nov. 17, 1300Z

Item9848: New Groups UI only allows users registered

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Urgent Closed Engine    
It is a major misunderstanding that the GROUPS and groups UI should check if users exist in WikiUsers or in .htpasswd.

I work in a company where we use simple apache based LDAP authentication.

I also use TopicUserMapping to map the login to a nice WikiName.

But not all users resister or wants to be registered. So we use a mix of WikiNames and login names in access rights and in groups.

This has always worked. From Cairo and up to 1.0.10.

But with the 1.1 changes all is broken. I cannot add logins to groups. I cannot remove deleted users. I cannot see members of a group even if they are in the topic setting because even GROUPS Macro checks if user exists.

All this checking must be removed or Foswiki becomes unusable for big corporate installations like mine.

I am working on getting these checks removed again

-- KennethLavrsen - 19 Oct 2010

I have fixed this

-- KennethLavrsen - 19 Oct 2010

Not fixed unless unit tests run. Reopen to fix unit tests.

-- GeorgeClark - 20 Oct 2010

Checked unit tests into trunk and release 1.1 - doesn't look like this patch made it into trunk, so leaving it open for now.

-- GeorgeClark - 20 Oct 2010

the last called problems stay - I copy from other Task: I have to add another problem.

  • I see duplicate username in the groups - I think there is another Task !?
  • I can't remove users from the group:
  • I test to add -> it works
  • I test to remove this user it works

If I look in the real text file with vim, I see the names in form of UserName. Then I remove all Main. pattern in the setting. After that I can remove the usernames from the group. But I think the form UserName should work ...

The duplicates are magic:

Members

SebastianKratzert, SebastianKratzert, AlexanderStein, AlexanderStein, StanislavPilischenko, FabianWiessner, StefanJenkner, PhilippSeidel, PhilippSeidel, MarioHaustein, MarioHaustein, MartinEnders, MatthiasAbleitner, KaiTimmer, KaiTimmer, AdminUser

naturally all oth them are only once in the text file - for remove you see the duplicates too but you only need to select one ... MAGIC

-- GuentherFischer - 20 Oct 2010

I am getting totally confused. This bug report is about adding and removing none-registered users.

If there are additional problems please raise separate bug items. A problem with Main prefix has nothing to do with this.

The issue with adding more to a bug report is that the risk that it is forgotten and never fixed is huge. We have seen this happen many times. So one bug item per error.

I am checking further fixes to the original problem on this report now.

-- KennethLavrsen - 20 Oct 2010

Reminder to myself. There is a cosmetic issue to fix when you remove two users and one is not member of group. The error message in browser reports the last user no matter if he was good or bad. The UI today will never expose this but I think it should be fixed because one day....

-- KennethLavrsen - 20 Oct 2010

Guenther I have raised Item9851 -Users prefixed with Main. cannot be removed with UI - to cover your other problem. I have confirmed it is an error.

-- KennethLavrsen - 20 Oct 2010

Kenneth,

I saw bugs (many Groups) with WikiGroups and report them to Item9838. After solving I've added other problems in managing/viewing WikiGroups. You are right and I wil do so in the furure to put the in a separate task. You have created a new task, but I don't see me problems added as described in Item9838. Because the problems were not solved with the patches in this task I does the adding (copy/paste) from the other task. What is wrong with that ...

-- GuentherFischer - 20 Oct 2010

Guenther.

The problem with many bugs on one item is that the risk of missing one is too great. And it seems this is happening again since you believe I missed something. Let me summarize.

- Item9838: WikiGroups runs into "premature end" error if you have many groups. The original bug report. We re-enabled some cache code that you confirmed solved your problem. In addition we added a setting so sites with many many groups can disable the UI for adding/removing which makes it load much faster.

- Then you report this which is hard to interpret
  • I see duplicate username in the groups - I think there is another Task !?
  • I can't remove users from the group:
  • I test to add -> it works
  • I test to remove this user it works
I get two errors from this. You see duplicate users. This has partly been fixed with . But in addition I can see that there is a duplicate user problem related to prefixed with Main. This is Item9851 which is not yet fixed as I write this. The other error where a duplicate user was added some cases was addressed with the fix of Item9811. I have confirmed that this also fixes removing a user added more than once to the list. Except when prefixed by Main.

So Guenther I believe we have addressed the 3 errors you reported on these bug items Item9838, Item9851, and Item9811 and this report.

If there is something I have missed then please raise a new report for it so we are sure we get it fixed. These bugs are key features and we will do everything to fix them in 1.1.1 and get 1.1.1 out asap.

And again reminder to myself added to the bottom of the page

There is a cosmetic issue to fix when you remove two users and one is not member of group. The error message in browser reports the last user no matter if he was good or bad. The UI today will never expose this but I think it should be fixed because one day....

-- KennethLavrsen - 20 Oct 2010

Fixed and committed

-- KennethLavrsen - 20 Oct 2010

Please have a look at Item9860 too ...

-- GuentherFischer - 21 Oct 2010

Hi Guys

I tried to apply the changes on checked in on the branch on the 4 files, but they are already different to what was distributed in 1.1.0 and I cant seem to get it working. What are my options now? I need this working, what do you suggest apart from waiting for the next release.

-- TerryRankine - 21 Oct 2010

Anyone? This is currently broken on our production wiki and we need to get it fixed. Can you please provide a 1.1.0 combined patch?

-- TerryRankine - 25 Oct 2010
 
Topic revision: r28 - 25 Oct 2010, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License