Item9528: Loading foswikilib kills jquery.foswiki lib

Priority: Urgent
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Reported By: MichaelDaum
Waiting For:
Last Change By: KennethLavrsen
At some point we have to take a stand and remove foswikilib.js all together. It really doesn't serve a purpose anymore right now.

What makes it worse is that it competes with jquery.foswiki.js in creating the global foswiki namespace. Only by accident does one or the other win. The current js dependencies say nothing about their relationship to each other. This is causing arbitrary trouble, i.e. due to their internal caching of foswiki.getPreference().

So let's kill foswikilib.js.

Any objections?

-- MichaelDaum - 23 Aug 2010

So, just by grepping the sources: Are the only ones still using that. The first and last one should most likely be fixed in this bug, we can let the (tm)wiki ones die, and Arthur will surely fix SlionSkin.

So I don't see why we should keep it any longer. We decided to use JQuery for 1.1, so be it.

-- OlivierRaginel - 23 Aug 2010

I will keep foswikilib.js in the core to properly deprecate it. so we don't produce a 404 for some non-core plugins not yet fixed. The non-core plugins affected like FormPlugin need a touch of themselves to use the new LIBJS dependency maker. For now PatternSkin, JQueryPlugin and TwistyPlugin will be touched. TwistyContrib is unmaintained code nowhere used anymore.

-- MichaelDaum - 23 Aug 2010

ItemTemplate edit

Summary Loading foswikilib kills jquery.foswiki lib
ReportedBy MichaelDaum
Codebase trunk
SVN Range
AppliesTo Engine
Priority Urgent
CurrentState Closed
Checkins distro:fbf27046b565 distro:127978d87266 Rev 8705 not found distro:c204f04247c6
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r14 - 04 Oct 2010, KennethLavrsen
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy