Foswiki on GitHub is open for business! Next release meeting: Monday September 29, 1300Z

Item9007: Cleanup of core templates as a result of HTML validation tests

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Normal Closed Engine   Main.PaulHarvey
-- SvenDowideit - 12 May 2010

Did a few more passes, committed to the wrong bug number, but fixed the links here (editing svn commit message is a pain and it's not worth it).

-- OlivierRaginel - 19 May 2010

Added a method to add a couple of attachments to the test topic object; had a go at fixing the twisty + h3 problems; show raw edit help inside the <noscript> block in TinyMCE; added missing table summary= attributes and wrapped all of them in %MAKETEXT%.

So 88 of 88 tests pass now, but in doing so a lot of noise is made still in the test output due to htmltidy being run against non-HTML output still

-- PaulHarvey - 22 May 2010

Need to add a form to the test topic in the unit tests

-- PaulHarvey - 04 Jun 2010

I think we're done - although the test topic that we build could have some extras to stress the templates a little more, eg. deeper breadcrumbs, topicmoved, links to non-existent topics, and more elaborate topic text in general.

If somebody finds issues there, feel free to re-open, but I think we've got a good start until we get a dynamic HTML validator tool that could be run live (eg Item2535).

-- PaulHarvey - 05 Jun 2010

brilliant.

excellent to see we're much further along the route of knowing where we have invalid output.

Please, however, don't reopen this task - we're better off allowing a little more separation in our tasks.

-- SvenDowideit - 05 Jun 2010

Foswikirev:7634 broke setting checkbox using url params.

For instance http://.../edit?MyCheckboxField=Foo,Bar won't set any value.

Reverting
          if ( $isSelected{$item} ) {
 -            $attrs{$item}{checked} = 'checked';
 +            # CGI::checkbox_group() will check these items
              push( @defaults, $item );
          }

... for now. Paul, any deeper reason behind this change?

-- MichaelDaum - 09 Jun 2010

Thanks Michael, looks like we need a unit test for that, will try to find time soon. Issue was multiple checked="checked" Attributes - set once by this code, and again by CGI which populated preset values from the @defaults array.

-- PaulHarvey - 10 Jun 2010

Continuing multiple checked="checked" attributes at Item9147

-- PaulHarvey - 12 Jun 2010
 
Topic revision: r36 - 04 Oct 2010, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License