Item2351: Use filetest 'access' instead of 'stat'

Priority: Urgent
Current State: Closed
Released In: 1.0.8
Target Release: patch
Applies To: Engine
Reported By: AndreLichtsteiner
Waiting For:
Last Change By: KennethLavrsen
The file .changes is hindered to be updated.

Foswiki checks file writing rights by default via 'stat'. On a file system like AFS, stat does not return the correct set of information. It is recommended to use 'access' instead.

Add to '': use filetest 'access';

-- AndreLichtsteiner - 12 Nov 2009

Any file under control of Foswiki's RCS should be writeable for it. why does it need a write access test? doesn't a simple -e suffice?

-- MichaelDaum - 12 Nov 2009

It would seem so, if we don't check for write-ability, we will get a meaninful error message I suppose when the file turns out not to be writeable (just the same as when a .txt is not writeable).

-- KoenMartens - 12 Nov 2009

Is this fixed?

-- KennethLavrsen - 25 Nov 2009

Oops, yes it is (by removing the checks completely).

ItemTemplate edit

Summary Use filetest 'access' instead of 'stat'
ReportedBy AndreLichtsteiner
Codebase 1.0.7
SVN Range Foswiki-1.0.7, Sun, 20 Sep 2009, build 5061
AppliesTo Engine
Priority Urgent
CurrentState Closed
Checkins distro:befe533fe2c3 distro:fe49890014ea
TargetRelease patch
ReleasedIn 1.0.8
Topic revision: r8 - 29 Nov 2009, KennethLavrsen
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy