Foswiki General Assembly will be held on 12th December 2019, 1200 UTC on Freenode IRC channel #foswiki-association. See AgendaTenthGeneralAssembly

You are here: Foswiki>Tasks Web>Component>NatEditPlugin>Item14660 (10 May 2019, MichaelDaum)Edit Attach

Item14660: missing tab id causes a javascript error

Priority: Normal
Current State: Waiting for Release
Released In: 2.1.7
Target Release: patch

Applies To: Extension
Component: JQueryPlugin, NatEditPlugin
Branches: master Release02x01 Item14288

Reported By: MichaelDaum
Waiting For:
Last Change By: MichaelDaum

Problem: http://...edit/web/topic/t=123&selectedtab=form does not work, selectedtab=2, selectedtab=permissions, selectedtab=settings= etc does just fine.

Bug 1: form.natedit.tmpl is missing an id param for the formular tab.
Bug 2: jquery.tabpane throws an exception when trying to select a non-existing tab,

Hotfix for Bug 1:

diff --git a/NatEditPlugin/templates/form.natedit.tmpl b/NatEditPlugin/templates/form.natedit.tmpl
index c4bb25f11..909ca4037 100644
--- a/NatEditPlugin/templates/form.natedit.tmpl
+++ b/NatEditPlugin/templates/form.natedit.tmpl
@@ -16,7 +16,7 @@
 %TMPL:DEF{"formname::standard"}%%QUERY{"form.name"}%%TMPL:END%
 
 %TMPL:DEF{"formtail"}% %TMPL:P{context="mandatoryfields" then="mandatory"}% %TMPL:END%
-%TAB{"%MAKETEXT{"Form"}%"}%
+%TAB{"%MAKETEXT{"Form"}%" id="form"}%
 <h2 ><nop>%TMPL:P{context="DBCachePluginEnabled" then="formname::dbcache" else="formname::standard"}%%TMPL:P{"changeform"}%</h2>
 <div class="foswikiFormSteps foswikiEditForm">
 <table class="foswikiLayoutTable foswikiFormTable">

-- MichaelDaum - 15 Mar 2018

ItemTemplate edit

Summary	missing tab id causes a javascript error
ReportedBy	MichaelDaum
Codebase
SVN Range
AppliesTo	Extension
Component	JQueryPlugin, NatEditPlugin
Priority	Normal
CurrentState	Waiting for Release
WaitingFor
Checkins	distro:74fe64980aa2 distro:cfa26cfde1e8 distro:c04c1d6199b9 distro:141033dad669
TargetRelease	patch
ReleasedIn	2.1.7
CheckinsOnBranches	master Release02x01 Item14288
trunkCheckins
masterCheckins	distro:74fe64980aa2 distro:c04c1d6199b9 distro:cfa26cfde1e8 distro:141033dad669
ItemBranchCheckins	distro:74fe64980aa2 distro:c04c1d6199b9
Release02x01Checkins	distro:cfa26cfde1e8 distro:141033dad669
Release02x00Checkins
Release01x01Checkins