Item14660: missing tab id causes a javascript error

pencil
Priority: Normal
Current State: Waiting for Release
Released In: 2.1.7
Target Release: patch
Applies To: Extension
Component: JQueryPlugin, NatEditPlugin
Branches: master Release02x01 Item14288
Reported By: MichaelDaum
Waiting For:
Last Change By: MichaelDaum
Problem: http://...edit/web/topic/t=123&selectedtab=form does not work, selectedtab=2, selectedtab=permissions, selectedtab=settings= etc does just fine.

  • Bug 1: form.natedit.tmpl is missing an id param for the formular tab.
  • Bug 2: jquery.tabpane throws an exception when trying to select a non-existing tab,

Hotfix for Bug 1:

diff --git a/NatEditPlugin/templates/form.natedit.tmpl b/NatEditPlugin/templates/form.natedit.tmpl
index c4bb25f11..909ca4037 100644
--- a/NatEditPlugin/templates/form.natedit.tmpl
+++ b/NatEditPlugin/templates/form.natedit.tmpl
@@ -16,7 +16,7 @@
 %TMPL:DEF{"formname::standard"}%%QUERY{"form.name"}%%TMPL:END%
 
 %TMPL:DEF{"formtail"}% %TMPL:P{context="mandatoryfields" then="mandatory"}% %TMPL:END%
-%TAB{"%MAKETEXT{"Form"}%"}%
+%TAB{"%MAKETEXT{"Form"}%" id="form"}%
 <h2 ><nop>%TMPL:P{context="DBCachePluginEnabled" then="formname::dbcache" else="formname::standard"}%%TMPL:P{"changeform"}%</h2>
 <div class="foswikiFormSteps foswikiEditForm">
 <table class="foswikiLayoutTable foswikiFormTable">

-- MichaelDaum - 15 Mar 2018

 
Topic revision: r4 - 10 May 2019, MichaelDaum
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy