You are here: Foswiki>Tasks Web>Item1432 (14 Apr 2009, SallyHoughton)Edit Attach

Item1432: foswikisiteskin missing the view topic option

pencil
Priority: Low
Current State: Waiting for Feedback
Released In:
Target Release: n/a
Applies To: Extension
Component: FoswikiSiteSkin
Branches:
Reported By: SallyHoughton
Waiting For: Main.WillNorris
Last Change By: SallyHoughton
The foswikisite skin has a "view raw topic" button and picture, but this doesn't change when viewing raw. This is in the latest version (1.1.4) of the plugin.

I've re-used some code from the old twiki quickmenu skin to change the view.foswikisite.tmpl template on my system and it seems to work well.

Oh - and the template was also forcing the create link to start a page in the "Home" web (which doesn't exist on my system).

template snippet was;
%TMPL:DEF{"top:toolbarbutton_create"}%<span><a href="%SCRIPTURL{"view"}%/Home/WebCreateNewTopic?topicparent=%TOPIC%" title="Create new topic"><img src="%PUBURL%/%SYSTEMWEB%/FoswikiSiteSkin/page_white_add.gif" width="16" height="16" /></a></span>%TMPL:END%
...
%TMPL:DEF{"top:toolbarbuttons"}%%TMPL:P{"top:toolbarbutton_edit"}%%TMPL:P{"top:toolbarbutton_attach"}%%TMPL:P{"top:toolbarbutton_rdiff"}%
%TMPL:P{"top:toolbarbutton_raw"}%%TMPL:P{"top:toolbarbutton_create"}%%TMPL:P{"top:toolbarbutton_print"}%%TMPL:P{"top:toolbarbutton_more"}
%%TMPL:END%

template snippet now is;
%TMPL:DEF{"top:toolbarbutton_view"}%<span><a href="%SCRIPTURL{"view"}%/%WEB%/%TOPIC%" title="View topic"><img src="%PUBURL%/%SYSTEMWEB%/DocumentGraphics/viewtopic.gif" width="16" height="16" /></a></span>%TMPL:END%
%TMPL:DEF{"top:toolbarbutton_create"}%<span><a href="%SCRIPTURL{"view"}%/%WEB%/WebCreateNewTopic?topicparent=%TOPIC%" title="Create new topic"><img src="%PUBURL%/%SYSTEMWEB%/FoswikiSiteSkin/page_white_add.gif" width="16" height="16" /></a></span>%TMPL:END%
...
%TMPL:DEF{"top:toolbarbuttons"}%%TMPL:P{"top:toolbarbutton_edit"}%%TMPL:P{"top:toolbarbutton_attach"}%%TMPL:P{"top:toolbarbutton_rdiff"}%
%IF{"defined raw" then='%TMPL:P{"top:toolbarbutton_view"}%' else='%TMPL:P{"top:toolbarbutton_raw"}'}%%TMPL:P{"top:toolbarbutton_create"}%%TMPL:P{"top:toolbarbutton_print"}%%TMPL:P{"top:toolbarbutton_more"}%%TMPL:END%

-- SallyHoughton - 09 Apr 2009


Regarding the "Create new topic" link -- a related task is Tasks.Item783. -- IsaacLin - 10 Apr 2009


although there is a normal "View Topic" link at the bottom of the page, this change is much better! a really nice refinement, thanks very much!

-- WillNorris - 10 Apr 2009

hmm, i'm going to have to back out this change because it's not working for me. i get this text after the buttons:

%IF{"defined raw" then='' else='

perhaps you could provide a diff please? or perhaps even request checkin rights to subversion.

-- WillNorris - 11 Apr 2009

my diff is as follows (but I can't see it on the foswiki home page as the horizontal scroll isn't working in my firefox viewer);

myserver # diff view.foswikisite.tmpl view.foswikisite.tmpl.old
Warning: missing newline at end of file view.foswikisite.tmpl.old
11c11
< %TMPL:DEF{"top:toolbarbutton_view"}%<span><a href="%SCRIPTURL{"view"}%/%WEB%/%TOPIC%" title="View topic"><img src="%PUBURL%/%SYSTEMWEB%/DocumentGraphics/viewtopic.gif" width="16" height="16" /></a></span>%TMPL:END%
---
> %TMPL:DEF{"top:toolbarbutton_create"}%<span><a href="%SCRIPTURL{"view"}%/Home/WebCreateNewTopic?topicparent=%TOPIC%" title="Create new topic"><img src="%PUBURL%/%SYSTEMWEB%/FoswikiSiteSkin/page_white_add.gif" width="16" height="16" /></a></span>%TMPL:END%
13,14d12
< %TMPL:DEF{"top:toolbarbutton_create"}%<span><a href="%SCRIPTURL{"view"}%/%WEB%/WebCreateNewTopic?topicparent=%TOPIC%" title="Create new topic"><img src="%PUBURL%/%SYSTEMWEB%/FoswikiSiteSkin/page_white_add.gif" width="16" height="16" /></a></span>%TMPL:END%
<
19c17
< %TMPL:DEF{"top:toolbarbuttons"}%%TMPL:P{"top:toolbarbutton_edit"}%%TMPL:P{"top:toolbarbutton_attach"}%%TMPL:P{"top:toolbarbutton_rdiff"}%%IF{"defined raw" then='%TMPL:P{"top:toolbarbutton_view"}%' else='%TMPL:P{"top:toolbarbutton_raw"}%'}%%TMPL:P{"top:toolbarbutton_create"}%%TMPL:P{"top:toolbarbutton_print"}%%TMPL:P{"top:toolbarbutton_more"}%%TMPL:END%
---
> %TMPL:DEF{"top:toolbarbuttons"}%%TMPL:P{"top:toolbarbutton_edit"}%%TMPL:P{"top:toolbarbutton_attach"}%%TMPL:P{"top:toolbarbutton_rdiff"}%%TMPL:P{"top:toolbarbutton_raw"}%%TMPL:P{"top:toolbarbutton_create"}%%TMPL:P{"top:toolbarbutton_print"}%%TMPL:P{"top:toolbarbutton_more"}%%TMPL:END%
27c25
< %TMPL:DEF{"breadcrumb:currenttopic"}%%TMPL:P{"breadcrumb:separator"}%<a href="%SCRIPTURL{view}%/%WEB%/%TOPIC%" title='%MAKETEXT{"Topic revision:"}% %REVINFO{format="$rev ($date - $time), !$wikiname"}%'>%TMPL:P{"breadcrumb:topic"}%</a>%TMPL:P{"breadcrumb:annotation"}%%TMPL:END%
---
> %TMPL:DEF{"breadcrumb:currenttopic"}%%TMPL:P{"breadcrumb:separator"}%<a href="%SCRIPTURL{view}%/%WEB%/%TOPIC%" title='%MAKETEXT{"Topic revision:"}% %REVINFO{format="$rev ($date - $time), !$wikiname"}%'>%TMPL:P{"breadcrumb:topic"}%</a>%TMPL:P{"breadcrumb:annotation"}%%TMPL:END%
myserver #

-- SallyHoughton - 14 Apr 2009

 

ItemTemplate edit

Summary foswikisiteskin missing the view topic option
ReportedBy SallyHoughton
Codebase 1.0.4
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Extension
Component FoswikiSiteSkin
Priority Low
CurrentState Waiting for Feedback
WaitingFor WillNorris
Checkins FoswikiSiteSkin:d0a7215208c6 FoswikiSiteSkin:92ec623d5e30 FoswikiSiteSkin:7b30f74c3ca6
TargetRelease n/a
ReleasedIn
Topic revision: r12 - 14 Apr 2009, SallyHoughton - This page was cached on 16 Sep 2021 - 20:57.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy