You are here: Foswiki>Tasks Web>Item13815 (16 Nov 2015, GeorgeClark)Edit Attach

Item13815: Typos in EditRowPlugin regular expressions.

pencil
Priority: Normal
Current State: Closed
Released In: 2.0.3
Target Release: n/a
Applies To: Extension
Component: EditRowPlugin
Branches: master
Reported By: JozefMojzis
Waiting For:
Last Change By: GeorgeClark
In the ERP is probably a typo in a regex.

diff --git a/EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/TableParser.pm b/EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/TableParser.pm
index cf5b9da..242262e 100644
--- a/EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/TableParser.pm
+++ b/EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/TableParser.pm
@@ -110,7 +110,7 @@ sub adjustSpec {
 
             # override the format
             # undo the encoding
-            $format =~ s/-([a-z\d][a-z\d])/chr(hex($1))/gie;
+            $format =~ s/-([a-f\d][a-f\d])/chr(hex($1))/gie;
             $attrs->{format} = $format;
         }
         if ( defined( $this->{params}->{"${pf}_headerrows"} ) ) {
-- JozefMojzis - 13 Oct 2015

Please describe in more detail what this patch actually fixes.

-- MichaelDaum - 14 Oct 2015

Trying to hex decode alpha strings containing a-z cause a warning. Needs to be a-f to be valid hex.
 ~ $ perl -w -e 'print STDOUT hex(g1) '
Illegal hexadecimal digit 'g' ignored at -e line 1.

-- GeorgeClark - 14 Oct 2015
 

ItemTemplate edit

Summary Typos in EditRowPlugin regular expressions.
ReportedBy JozefMojzis
Codebase 2.0.2, 2.0.1, 2.0.0, trunk
SVN Range
AppliesTo Extension
Component EditRowPlugin
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:2f492a6d54c3
TargetRelease n/a
ReleasedIn 2.0.3
CheckinsOnBranches master
trunkCheckins
masterCheckins distro:2f492a6d54c3
ItemBranchCheckins
Release01x01Checkins
Topic revision: r7 - 16 Nov 2015, GeorgeClark - This page was cached on 02 Jul 2016 - 11:41.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License