Item13065: jsonrpc script doesn't log events to the Foswiki event log.

Priority: Urgent
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Engine
Component: FoswikiUI, JsonRpcContrib
Branches: master
Reported By: GeorgeClark
Waiting For:
Last Change By: MichaelDaum
All scripts should create events unless masked. jsonrpc doesn't conform.

We also should audit to make sure nothing else has been missed with the default extensions. Or preferably move the log action out of the individual UI:: classes and up into UI itself.

# Whether or not to log different actions in the events log.
# Information in the events log is used in gathering web statistics,
# and is useful as an audit trail of Foswiki activity. Actions
# not listed here will be logged by default.  To disable logging of an action,
# add it to this list if not already present, and set value to 0.
$Foswiki::cfg{Log}{Action} = {
    view     => 1,
    search   => 1,
    changes  => 1,
    rdiff    => 1,
    compare  => 1,
    edit     => 1,
    save     => 1,
    upload   => 1,
    attach   => 1,
    rename   => 1,
    register => 1,
    rest     => 1,
    viewfile => 1,

-- GeorgeClark - 02 Nov 2014

Have to reopen and raise to urgent as the added call to the logger is not backwards compatible and will break everything jsonrpc-ish on < 1.2.0

-- MichaelDaum - 23 Feb 2015

Fixed. Changed to use deprecated logEvent.

-- GeorgeClark - 23 Feb 2015

Why not use Foswiki::Func?

-- MichaelDaum - 23 Feb 2015

Okay, changed to use Foswiki::Func. Proposal for 1.2 was to make the Logger API part of the public API and allow direct calls. But the proposal also says extensions should continue to use writeEvent.

-- GeorgeClark - 23 Feb 2015
Topic revision: r8 - 08 Jul 2015, MichaelDaum - This page was cached on 14 Dec 2018 - 15:21.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy