Item1267: statistics cronjob does not work

Priority: Normal
Current State: Closed
Released In: 1.0.4
Target Release: patch
Applies To: Engine
Reported By: MichaelDaum
Waiting For:
Last Change By: KennethLavrsen
... as it tries to save the WebStatistics topics as guest user: should be user admin. Even ./statistics -user AdminGroup does not work.

/me hacking a workaround for Foswiki::LoginManager::loadSession() -
-    return $authUser if $session->inContext('command_line');
+    return $Foswiki::cfg{AdminUserLogin} if $session->inContext('command_line');

-- MichaelDaum - 12 Mar 2009

Looks like you know what's wrong. So fix it.

-- CrawfordCurrie - 12 Mar 2009

Fixed it in release branch. Not able to work on trunk as I need a working env today.

There's another twist in this bug report, that is -user SomeUser does not work on the cmdline. The above patch obviously does not address this. Lowering it to normal not to block the release.

-- MichaelDaum - 12 Mar 2009

I would bet the fix for this feature would be:
-    return $Foswiki::cfg{AdminUserLogin} if $session->inContext('command_line');
+    return $session->{request}->{remote_user} || $Foswiki::cfg{AdminUserLogin}
+      if $session->inContext('command_line');

But I had such a crappy day today that I fear breaking everything by committing this change. Maybe tomorrow if nobody has done it already.

-- OlivierRaginel - 12 Mar 2009

Why didn't you run the unit tests before checking in this, Michael?

They are totally blown.

-- KennethLavrsen - 15 Mar 2009

Maybe because he was in a hurry at a customer.

Anyway, I've checked in something that makes all unit test work, and still does what Michael wanted (at least how I understood it).

So I'm closing this. Micha, please re-open it if I'm mistaken.

-- OlivierRaginel - 15 Mar 2009

Shouldn't this one be marked as "Waiting for Release"? Just came back from holidays hoping to see this bug fixed in 1.0.4...

-- MichaelDaum - 17 Mar 2009

ItemTemplate edit

Summary statistics cronjob does not work
ReportedBy MichaelDaum
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Engine
Priority Normal
CurrentState Closed
Checkins distro:8acf3442365e distro:e34015f7d7b5
TargetRelease patch
ReleasedIn 1.0.4
Topic revision: r10 - 19 Mar 2009, KennethLavrsen - This page was cached on 14 Jan 2020 - 15:21.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy