Item12315: JQueryPlugin from Foswiki 1.1.6 breaks Shortcut in ActionTrackerPlugin

pencil
Priority: Normal
Current State: Closed
Released In: n/a
Target Release: n/a
Applies To: Extension
Component: ActionTrackerPlugin
Branches: trunk
Reported By: TarekUnger
Waiting For:
Last Change By: PhilippLeufke
With Foswiki 1.1.6 the ActionTrackerPlugin state shortcut (direct drop-down switching between open and close) no longer works. It not even sends a rest request to the server.

The Culprit seems to be the JQueryPlugin. The same Problem occurs if i update a 1.1.5 Foswiki with the new JQueryPlugin.

Its the same with a fresh installed Foswiki and the ActionTrackerPlugin, even if i use the "old" JQuery version 1.7.1.

-- TarekUnger - 27 Dec 2012

I'm not very experienced in JavaScript, but i get it back to work if i replace the livequery event bindings with "normal" ones...

.../pub/System/ActionTrackerPlugin/

--- atp_src.js  2012-12-28 09:40:36.000000000 +0100
+++ atp.uncompressed.js 2012-12-28 10:55:36.000000000 +0100
@@ -24,9 +24,11 @@
            }
        });
     };
-
-    $("select.atp_update").livequery("change", restUpdate);
-    $("input.atp_update").livequery("click", restUpdate);
+
+       $('document').ready ( function() {
+           $('select.atp_update').change( restUpdate );
+           $('input.atp_update').click( restUpdate );
+       } );

     $('a.atp_edit').livequery("click", function(event) {
        var div = $("#atp_editor");

-- TarekUnger - 28 Dec 2012

Seems to be more of an error in Foswiki::Plugins::ActionTrackerPlugin::JQuery not depending on livequery.

-- MichaelDaum - 29 Dec 2012

Unfortunately no. Even after adding LiveQuery to {JQueryPlugin}{DefaultPlugins} it does not work.

-- TarekUnger - 02 Jan 2013

Is there any update on this as I have just updated my foswiki installation and the drop-down status updates don't work anymore.

Clicking to edit actions also goes to a new page rather than a pop-up and when you save the page there it comes up with a suspicious action error, but I don't know if this is related to this bug - I suspect not.

-- EdMcDonagh - 21 Feb 2013

The first problem, with the status drop-down, is due to a change in JQuery (outside of Foswiki's control). I am re-coding for use with more recent versions of JQuery/the livequery plugin, but until then you may need to revert your livequeryplugin version back several versions - sorry, I don't know how many, but 1.3.1 is definitely missing the correct function. Or you can hack in TarekUnger's fix-that-isn't-a-fix above - it will make it mostly work.

The second problem is probably due to incorrect processing of the edit page for adding in the strikeone keys. You can work around it by simply confirming.

-- CrawfordCurrie - 21 Feb 2013

Fixed in 2.4.10

-- CrawfordCurrie - 27 Feb 2013

Add missing Config.spec


Although this bug should have been fixed, it is still there for me. However, as I don't know to what extent this might be related to my very own installation, I decided to rather file a new bug instead of opening this one again: Item12507

-- PhilippLeufke - 24 May 2013
 
Topic revision: r13 - 24 May 2013, PhilippLeufke - This page was cached on 25 Feb 2021 - 06:17.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy