You are here: Foswiki>Tasks Web>Item12198 (02 Dec 2012, GeorgeClark)Edit Attach

Item12198: Foswiki::Func::checkAccessPermission overrides meta text, and $text option is non-functional

pencil
Priority: Urgent
Current State: Closed
Released In: 1.1.6
Target Release: patch
Applies To: Engine
Component: FoswikiFunc
Branches: Release01x01
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
MichaelDaum found and fixed this issue as part of Item11983. It wasn't really related to the Store performance fix, back-porting to 1.1.5

  • Foswiki::Func::checkAccessPermissions could override the $meta object's text by accident; before, the $text parameter was non-functional as well when checkAccessPermissions was called with a "loaded" meta object.
  • Fixed the respective unit tests testing for the wrong result: an ALLOW in META overrides the ALLOW in TEXT so the access was granted, not permitted.

-- GeorgeClark - 27 Oct 2012

 

ItemTemplate edit

Summary Foswiki::Func::checkAccessPermission overrides meta text, and $text option is non-functional
ReportedBy GeorgeClark
Codebase 1.1.5, trunk
SVN Range
AppliesTo Engine
Component FoswikiFunc
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:bd7dcb864c07
TargetRelease patch
ReleasedIn 1.1.6
CheckinsOnBranches Release01x01
trunkCheckins
Release01x01Checkins distro:bd7dcb864c07
Topic revision: r3 - 02 Dec 2012, GeorgeClark - This page was cached on 10 Dec 2016 - 18:17.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License