You are here: Foswiki>Tasks Web>Item11945 (02 Dec 2012, GeorgeClark)Edit Attach

Item11945: Log when missing/invalid formfield types are used, make dataform object cache more robust

pencil
Priority: Urgent
Current State: Closed
Released In: 1.1.6
Target Release: patch
Applies To: Engine
Component: FoswikiForm
Branches: Release01x01 trunk
Reported By: MichaelDaum
Waiting For:
Last Change By: GeorgeClark
When a Foswiki::Form is constructed it is cached in the session object's forms hash .... even though it only has been build up half way ... as a result of an access control exception.

Also: it might get cached or looked up under the wrong key.

-- MichaelDaum - 14 Jun 2012

Re-opened to fix test breakage

Re-titled for release notes

-- PaulHarvey - 16 Jun 2012

Breaks more unit tests:

# Following broken by Foswikirev:14981 - Item11945 - MichaelDaum
#../bin/TestRunner.pl -clean  HTMLValidationTests::verify_switchboard_function_edit_default HTMLValidationTests::verify_switchboard_function_edit_pattern HTMLValidationTests::verify_switchboard_function_edit_plain HTMLValidationTests::verify_switchboard_function_edit_print

-- GeorgeClark - 23 Aug 2012

Not related to this checkin and fixed as part of Item12079. This was an error in TwistyPlugin.

-- MichaelDaum - 19 Sep 2012

this has caused Item12228, which I'm investigating for 1.1.6

changes like this should never be made without unit tests that show the problem they are fixing. Specifically, the partially evaluated form was cached to prevent infinite recursion - and yes, that needs a unit test badly.

-- SvenDowideit - 07 Nov 2012

There've been a couple of serious programming errors fixed in distro:2b941c92afa3. Some of them are pretty obvious, like using normalizeWebTopicName before caching a form obj under a key constructed on the web and topic names...

-- MichaelDaum - 07 Nov 2012
 

ItemTemplate edit

Summary Log when missing/invalid formfield types are used, make dataform object cache more robust
ReportedBy MichaelDaum
Codebase 1.1.5, trunk
SVN Range
AppliesTo Engine
Component FoswikiForm
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:2b941c92afa3 distro:76724825c68b distro:ef63734effc6 distro:ce203f4e7aa4
TargetRelease patch
ReleasedIn 1.1.6
CheckinsOnBranches Release01x01 trunk
trunkCheckins distro:2b941c92afa3 distro:ce203f4e7aa4
Release01x01Checkins distro:76724825c68b distro:ef63734effc6
Topic revision: r13 - 02 Dec 2012, GeorgeClark - This page was cached on 26 Jun 2016 - 22:58.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License