Item11648: Add NatEditPlugin to core

pencil
Priority: Enhancement
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Extension
Component: NatEditPlugin
Branches: trunk
Reported By: CrawfordCurrie
Waiting For:
Last Change By: GeorgeClark
Add NatEditPlugin to core

  • Remove surplus and out-of-band dependencies
  • Audit for security problems
  • tidy
  • Implement fallback for non-JS sites (if required)

-- CrawfordCurrie - 15 Mar 2012

I can't edit on trunk.foswiki.org, tried clearing my browser cache. See attached screenshot.

There were no errors retrieving any files from foswiki.org according to firebug's net panel. Iceweasel 10.0.2

  • Screenshot_-_240312_-_17:59:15.png:
    Screenshot - 240312 - 17:59:15.png

Additionally: we need to update docs for nojs installations, to remove natedit from their SKIN path (previously they just had to change the {Validation}{Method}).

-- PaulHarvey - 24 Mar 2012

Additionally: WARNING: NatEditPlugin has no module defined, it might not load! on each WysiwygPlugin test

-- PaulHarvey - 24 Mar 2012

trunk is missing

$Foswiki::cfg{JQueryPlugin}{Plugins}{NatEdit}{Module} = 'Foswiki::Plugins::NatEditPlugin::NATEDIT';
$Foswiki::cfg{JQueryPlugin}{Plugins}{NatEdit}{Enabled} = 1;

So its css and js isn't loaded. Fixed now.

-- MichaelDaum - 26 Mar 2012

can't switch back to wysiwyg, once in raw edit mode

-- MichaelDaum - 26 Mar 2012

Ah, I thought that breakage was unique to the selenium test environment - well, I'll try to have a go at this on the weekend.

-- PaulHarvey - 28 Mar 2012

Guys,

I have serious concerns that NatEdit isn't worth it if we lose the permissions editor tab. That is the killer feature for NatEdit, so I really want to address this problem.

At the same time, I have big problems with SetVariablePlugin. We've tried several times to fix the (save) performance issues, and I am thankful and appreciative to Michael for those efforts, but in the end I have had to disable the %GET/SET features entirely, due to mysterious and difficult-to-reproduce crashes (it's sometimes dying trying to expand some template recursively... I suspect I have a plugin somewhere with improper default value due to missing TMPL:DEFs in save context, all I know is that the problem is gone after nuking any expandCommonVariables-on-save).

Even if we fix these obscure crashes, I'm not convinced the %GET/%SET approach as taken in SetVariablePlugin is the correct one for core.

So, can we please think of a way to:
  • Keep the permissions tab somehow.
  • Maybe that means moving the Set+ and Local+ stuff to core. Let me know if you agree in principle, I'll write up the proposal.
  • RestPlugin might be relevant.

-- PaulHarvey - 29 Mar 2012 - 23:41

A REST handler for the get/set operations would seem to be the logical approach. Whether that merits importing the RestPlugin - which is a whole other can of worms - is debatable.

-- CrawfordCurrie - 30 Mar 2012

Saving preference variables is done as part of a normal save. So there's no REST involved here.

-- MichaelDaum - 30 Mar 2012

I don't have a problem with importing the ability to set preferences during a save to the core - it's only a few lines of code. See AddRequestSetToCore

-- CrawfordCurrie - 07 Apr 2012

Created Item11959 to deal with the WYSIWYG transition issue

-- PaulHarvey - 20 Jun 2012

Current changes break it for all foswiki < 1.2.0. There's also an issue with the recent changes to the "save" code causing performance problems.

-- MichaelDaum - 25 Jun 2012

Removed dependency on SetVariablePlugin. Please test.

-- MichaelDaum - 18 Jun 2013
 

ItemTemplate edit

Summary Add NatEditPlugin to core
ReportedBy CrawfordCurrie
Codebase trunk
SVN Range
AppliesTo Extension
Component NatEditPlugin
Priority Enhancement
CurrentState Closed
WaitingFor
Checkins distro:05735d6ab9ca distro:baec976debe8 distro:6c43a2de9b7a distro:608aa40676f7 distro:e9990d237c96 distro:22d9af32ee58 distro:4d9b8b81e43b distro:3b0af10cd12a distro:89cc9279f283 distro:1a6a3ba829aa distro:2a77428356b7 distro:89f0e5e572ee distro:d2cf7743e63e distro:da6b27d23c33 distro:820d68a3995e distro:65609a39d587 distro:50c0cf1dcd46 distro:ac42a4cec31e distro:da353ae84b03 Rev 14481 not found distro:e3bee37e1bf0 distro:ddde82b37a23 distro:f0c69e10a0ff Rev 15074 not found Rev 15075 not found Rev 15077 not found Rev 15085 not found Rev 15086 not found distro:2cd8d69bda9a distro:2d9407a6c058 distro:9d006d879870 distro:9ce6bebdb869 distro:119d79d64fd4 distro:567426264ae5 distro:f221449d2a63 distro:c03b50fdecdc distro:78d74e6cfb6a distro:a9c68e2ea6b3 distro:e6eaec7c0364 distro:ec9cdf404eb9 Rev 16839 not found
TargetRelease major
ReleasedIn 2.0.0
CheckinsOnBranches trunk
trunkCheckins distro:05735d6ab9ca distro:baec976debe8 distro:6c43a2de9b7a distro:608aa40676f7 distro:e9990d237c96 distro:22d9af32ee58 distro:4d9b8b81e43b distro:3b0af10cd12a distro:89cc9279f283 distro:1a6a3ba829aa distro:2a77428356b7 distro:89f0e5e572ee distro:d2cf7743e63e distro:da6b27d23c33 distro:820d68a3995e distro:65609a39d587 distro:50c0cf1dcd46 distro:ac42a4cec31e distro:da353ae84b03 Rev 14481 not found distro:e3bee37e1bf0 distro:ddde82b37a23 distro:f0c69e10a0ff Rev 15074 not found Rev 15075 not found Rev 15077 not found Rev 15085 not found Rev 15086 not found distro:2cd8d69bda9a distro:2d9407a6c058 distro:9d006d879870 distro:9ce6bebdb869 distro:119d79d64fd4 distro:567426264ae5 distro:f221449d2a63 distro:c03b50fdecdc distro:78d74e6cfb6a distro:a9c68e2ea6b3 distro:e6eaec7c0364 distro:ec9cdf404eb9 Rev 16839 not found
Release01x01Checkins
Topic revision: r55 - 05 Jul 2015, GeorgeClark - This page was cached on 27 May 2016 - 14:28.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License