Foswiki on GitHub is open for business! Next release meeting: Monday September 15, 1300Z

Item11193: typo in lib/Foswiki/PageCache.pm causing all (cached) pages to be delivered with a Last-Modified: header set to 01 Jan 1970:

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Normal Closed Engine FoswikiCache  
There's a typo in lib/Foswiki/PageCache.pm causing all (cached) pages to be delivered with a Last-Modified: header set to 01 Jan 1970:

-- a/lib/Foswiki/PageCache.pm
+++ b/lib/Foswiki/PageCache.pm
@@ -205,7 +205,7 @@ sub cachePage {
             $text = Compress::Zlib::memGzip($text);
         }
         $etag = $time;
-        $lastModified = Foswiki::Time::formatTime( $time, 'http', 'gmtime' );
+        $lastModified = Foswiki::Time::formatTime( $time, '$http', 'gmtime' );
     }
 
     my $headers   = $session->{response}->headers();

Please check the formatTime() definition at lib/Foswiki/Time.pm:250 and compare a similar use at lib/Foswiki.pm:840

-- FlorianSchlichting - 21 Oct 2011

 

ItemTemplate edit

Summary typo in lib/Foswiki/PageCache.pm causing all (cached) pages to be delivered with a Last-Modified: header set to 01 Jan 1970:
ReportedBy FlorianSchlichting
Codebase 1.1.3, trunk
SVN Range
AppliesTo Engine
Component FoswikiCache
Priority Normal
CurrentState Closed
WaitingFor
Checkins Foswikirev:12827 Foswikirev:12828
TargetRelease patch
ReleasedIn 1.1.4
Topic revision: r5 - 17 Dec 2011, GeorgeClark
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License