Item8255: <[endif]--> being displayed at the top in IE

pencil
Priority: Normal
Current State: Closed
Released In:
Target Release:
Applies To: Extension
Component: SafeWikiPlugin
Branches:
I have Safe Wiki Plugin with Foswiki 1.0.6. However, in IE browsers at the top I can see <[endif]-->. I think this has got to do with code in the SafeWikiPlugin.pm file. What is going wrong?

-- GuruprasadIyer - 26 Aug 2009

SafeWikiPlugin is a new extension and it will be a while before all the skins and other plugins will be fully compatible with it.

It's probably stripping the <script> tags, and IE doesn't know what to do with the <!-- conditional.. What skin are you using?

-- PaulHarvey - 26 Aug 2009

The default Pattern skin.

-- GuruprasadIyer - 31 Aug 2009

I've confirmed this bug on trunk with IE6. Screenshot attached. Apparently SWP is stripping an exclamation mark out of the closing comment tag, ie:

With SWP:
<[endif]-->

Without SWP:
<![endif]-->

-- PaulHarvey - 12 Oct 2009
 

  • IE6 showing defect:
    Screenshot-WebHome  Main  Foswiki - Microsoft Internet Explorer 6.0.png


Patch fixes the problem for me. Feel free to re-open if necessary (with more information including list of plugins installed).

-- PaulHarvey - 12 Oct 2009
This issue is still open in Foswiki 1.0.8; I can see the endif tag at the top. I am using IE8. Is there a patch for this?

-- GuruprasadIyer - 22 Dec 2009

If you were using the latest official release of SafeWikiPlugin, please check for a newer release shortly - CrawfordCurrie is going to upload a new version which should include the checkin to fix this problem.

If you were already running the latest svn checkout from trunk, this will need further analysis (set this task back to WaitingFor me).

-- PaulHarvey - 22 Dec 2009

I am using the latest official release of the SWP; hence, waiting for CrawfordCurrie.

-- GuruprasadIyer - 23 Dec 2009

I appreciate that CrawfordCurrie is the authority on SWP, but as I am the one who committed the very simple fix for this problem I am interested in understanding why it didn't work for you, hopefully CC won't mind if I try to save him some work.

I can't reproduce the problem. Could you please check line 58 of your copy of trunk/SafeWikiPlugin/lib/Foswiki/Plugins/SafeWikiPlugin.pm, that it matches the current change as per SafeWikiPlugin:c2f6a79eb380 (note the inserted ! character)?

Crawford uploaded a new version but somehow the foswiki.org/Extensions web did not get a version bump. This means that if you use configure, it will report the old SWP as still being up to date, and probably if you use deb packages they may not have been updated either. If you did not re-install SWP on or after 22 Dec, you are probably still running the previous version.

Anyway, if your line 58 of SafeWikiPlugin.pm is correct, then this is strange. It may be useful to File-> Save As and attach a copy of the HTML that is served to your browser, one version with SWP enabled and the other without. Preferably with ?skin=pattern or classic to eliminate any artefacts from a custom skin.

-- PaulHarvey - 28 Dec 2009

The problem is fixed now. I downloaded the latest version of SWP uploaded by CrawfordCurrie on 22nd Dec. Thanks for your help PaulHarvey!

-- GuruprasadIyer - 31 Dec 2009

ItemTemplate edit

Summary <[endif]--> being displayed at the top in IE
ReportedBy Foswiki:Main.GuruprasadIyer
Codebase 1.0.8
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Extension
Component SafeWikiPlugin
Priority Normal
CurrentState Closed
WaitingFor CrawfordCurrie, GuruprasadIyer
Checkins SafeWikiPlugin:c2f6a79eb380 SafeWikiPlugin:e13f5a7f26e1
ReleasedIn
Topic revision: r14 - 31 Dec 2009, GuruprasadIyer - This page was cached on 15 Jun 2017 - 14:47.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License