Item9944: configure fails to upgrade a plugin if cache is enabled

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Urgent Closed Engine Configure  
When you enable the cache (all default settings) and in configure try to upgrade an extension configure fails with this error

can't create lockfile $Foswiki::cfg{WorkingDir}/tmp/foswiki_db.lock at /var/www/foswiki11/lib/Foswiki/Cache/DB_File.pm line 157.

The lock file is already there. The problem is that at this point in time $Foswiki::cfg{WorkingDir} has no value.

This needs to be fixed in 1.1.2

-- KennethLavrsen - 03 Nov 2010

George and I figured out what the problem was and George has checked in fix.

I assume we could put the bug in Waiting For Release now but maybe George has some additional things he wanted to check.

-- KennethLavrsen - 03 Nov 2010

I was thinking that there should probably be a SMELL here. If a topic updated by the extension installer was cached, will the cache be stale after the install if we disable the extension? In the long run, the fix probably needs to be deeper, but disabling extensions that use the Foswiki::cfg hash is the quick fix. It would be better if the extension installer component could get a true expansion of the configuration instead of the un-expanded version used by configure. Another option would be to set a "configure" context so that extensions would know they were being run from the configure interface.

-- Foswiki:Main.GeorgeClark - 03 Nov 2010

Added SMELL to trunk - addressing the issue more extensively is probably a 1.2 / 2.0 issue. Changing to waiting for release.

-- GeorgeClark - 03 Nov 2010
 

ItemTemplate edit

Summary configure fails to upgrade a plugin if cache is enabled
ReportedBy KennethLavrsen
Codebase 1.1.1
SVN Range
AppliesTo Engine
Component Configure
Priority Urgent
CurrentState Closed
WaitingFor
Checkins Foswikirev:9828 Foswikirev:9829 Foswikirev:9836 Foswikirev:9837
TargetRelease patch
ReleasedIn 1.1.2
Topic revision: r10 - 10 Nov 2010, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License