Item9857: CommentPlugin templates changes have caused trouble for ActionTrackerPlugin and plain use of tableprepend

Priority: Urgent
Current State: Closed
Released In: 1.1.1
Target Release: patch
Applies To: Extension
Component: CommentPlugin
Reported By: BobCorless
Waiting For: Main.KennethLavrsen
Last Change By: KennethLavrsen
In the Sandbox/CommentPluginExamples you can "test" the various option for types of comment.

The tableprepend option is now broken in 1.1.0

Entering a new comment results in a blank entry in the table and an incorrect default date and time.

-- BobCorless - 21 Oct 2010

I cannot reproduce this

Please check that you do not have some old template that redefines the one we ship.

I copied the entire example from Sandbox and I can add lines just fine. I get the right date and the right content.

-- KennethLavrsen - 21 Oct 2010

I've "re-installed" the Comment plugin replacing all the standard templates and get the same result.

When I add an action in the CommentPluginExamples, it does not correctly populate the "Assigned to" name. It just enters "Main."

-- BobCorless - 21 Oct 2010

I found the problem. I had a UserCommentsTemplate which had an error in the TablePrepend definition. It appears the the code in 0.9 is more forgiving than 1.1.0 because I just tested in 0.9 and the tableprepend works. I copied that UserCommentsTemplate from 0.9 to 1.1 and tableprepend gives the symptoms above. I manually changed the UserCommentsTemplate in 1.1 and it is working as designed. So a combination of user error and some code change that was more robust in in its processing.

-- BobCorless - 21 Oct 2010

I've reverted back to a vanilla USerCommentsTemplate based upon the CommentPluginTemplate. So for now I've lost all my changes from servertime to localtime. No matter as I should not have any errors from the previosu install. I have the CommentPlugin in the {PluginsOrder} to take precedence over ActionTracker for the template. However, now that I have the new action tracker installed, the example on the Sandbox/CommentPluginExamples for actions now looks like this.

Can you check whether using the CommentPlugin for the ActionTracker responds as above? Seems strange to me. Of course it could be me in which case I'd appreciate any pointers as to where to unravel this issue. Thanks.

-- BobCorless - 21 Oct 2010

Someone has changed the CommentPlugin do the templates "look" nicer.

He added tailing \ and split the lines. I will revert all these and release a new CommentPlugin.

I will revert them for all the templates because I bet other applications will also fail.

For ATP it simply cannot cope with a multiline ACTION.

-- KennethLavrsen - 21 Oct 2010

Thanks. Glad to see I'm not going mad!

-- BobCorless - 21 Oct 2010

I have reverted ALL the changes done to CommentPluginTemplates

Many of the templates had newlines added or removed.

Many had \ at the end of the line which will often not work. It will all depend on the use of the template. If the template is used at the end of a line it may work. But if someone puts the COMMENT tag inside something else these \ will depend on CommonTagHandlers in plugins and formatted searches people have made.

We have added and removed new lines from Comment templates for many years and things have stabilized. Don't touch it. Add new. Do not change.

I also removed the Chili. I fear this can also interfere in ways we cannot predict

And it is of very little use.

When you need the syntax highlight, you are in edit mode, and then it does not matter because then it does not work.

CommentPluginTemplate is a templates definition document. It is not documentation. It is not meant to look nice. It is meant to work.

-- KennethLavrsen - 21 Oct 2010

I have released a fixed CommentPlugin on so people can update before we have 1.1.1 out

-- KennethLavrsen - 21 Oct 2010

ItemTemplate edit

Summary CommentPlugin templates changes have caused trouble for ActionTrackerPlugin and plain use of tableprepend
ReportedBy BobCorless
Codebase 1.1.0
SVN Range
AppliesTo Extension
Component CommentPlugin
Priority Urgent
CurrentState Closed
WaitingFor KennethLavrsen
Checkins distro:58467a9e669a distro:d121985b4bf8
TargetRelease patch
ReleasedIn 1.1.1
Topic revision: r12 - 25 Oct 2010, KennethLavrsen - This page was cached on 14 Jan 2020 - 09:50.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy