Item9828: ImageGalleryPlugin not working on Foswiki 1.1.0 because of bug in JQueryPlugin

Priority: Urgent
Current State: Closed
Released In: 1.1.1
Target Release: patch
Applies To: Extension
Component: JQueryPlugin
Reported By: HolstenerLiesel
Waiting For:
Last Change By: KennethLavrsen
Trying to post an %IMAGEGALLERY% to a topic results in an oops page:
Can't call method "maketext" on an undefined value at foswiki/lib/Foswiki/Plugins/JQueryPlugin/ line 60
This does however not happen when I post the %IMAGEGALLERY% under an %UPLOADFORM% (which I had to patch according to Item9065).

Changing lib/Foswiki/Plugins/JQueryPlugin/ line 60 from
my $counterText = $this->{session}->{i18n}->maketext("Image [_1] of [_2]", "{x}", "{y}");
my $counterText = $this->{session}->i18n->maketext("Image [_1] of [_2]", "{x}", "{y}");
fixes this.

-- HolstenerLiesel - 14 Oct 2010

Looks like nobrainer code syntax bug.

Checking in assuming Holstener is correct.

Bumping revision and re-releasing plugin

-- KennethLavrsen - 19 Oct 2010

also updated ImageGalleryPlugins's DEPENDENCIES to this version (3.74).

-- WillNorris - 19 Oct 2010
Topic revision: r9 - 25 Oct 2010, KennethLavrsen - This page was cached on 17 Sep 2021 - 01:04.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy