Item9773: Extension backup directories should be deleted after successful tar/zip archive

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Normal Closed Engine configure  
1.1 added a new extension backup which replaced the file rename technique

  • Installed extension is copied to working/configure/backup/[NameOfExtension]-[timestamp]
  • tar or zip are used to make an archive of the backup directory: working/configure/backup/[NameOfExtension]-[timestamp].[tgz/zip]
  • original backup directory is deleted currently disabled

This was disabled until there was enough experience with the backup process. There have been no reports of issues, so the delete option should be enabled.

Flag is set in Foswiki/Configure/Package.pm around line 667
          Foswiki::Configure::Util::createArchive( $bkname, $bkdir, '0' )      # 3rd operand set to true will remove archived files.

See http://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Configure::Util#StaticMethod_createArchive_40_36name_44_36dir_44_36delete_41

-- GeorgeClark - 30 Sep 2010

I did not even know this existed and never tried it.

Why would this be a release blocker? We did not have it in 1.0.10 either.

-- KennethLavrsen - 01 Oct 2010

Only to get comment. It was a reminder that I was supposed to change that flag so we don't leave redundant backups around in the system, and to draw comment from you about a last minute change. We can leave it or change it - I probably should have done it for the RC.

-- GeorgeClark - 01 Oct 2010

I'm changing this back to normal. I don't believe there is much risk to going ahead with enabling the delete though. There is not very good test coverage for the delete operation so I'll add some unit tests and we can defer this back to 1.1.1

-- GeorgeClark - 02 Oct 2010

Added unit tests to verify operation of the delete flag. Also documented SMELL in Package.pm - to remind that the flag needs to be updated.

-- GeorgeClark - 02 Oct 2010
 

ItemTemplate edit

Summary Extension backup directories should be deleted after successful tar/zip archive
ReportedBy GeorgeClark
Codebase 1.1.0, 1.1.0 beta1, trunk
SVN Range
AppliesTo Engine
Component configure
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:391adadd4a4c distro:4418c54e1538 distro:f08d418fdbb8
TargetRelease patch
ReleasedIn 1.1.1
Topic revision: r11 - 25 Oct 2010, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License