cross
New Foswiki release 2.1.6 is available with important security fixes.
Sourceforge foswiki email lists being discontinued. Subscribe to the new Foswiki announce and discuss lists at MailingLists
You are here: Foswiki>Tasks Web>Item972 (23 Feb 2009, KennethLavrsen)Edit Attach

Item972: Undefined subroutine &Foswiki::Form::Select::TAINT called

pencil
Priority: Urgent
Current State: Closed
Released In: 1.0.1
Target Release: patch
Applies To: Engine
Component:
Branches:
Reported By: ChristianSchmidt
Waiting For:
Last Change By: KennethLavrsen
I built a small app with forms in TWiki. Two days ago I switched to foswiki and I get the following error, when I try to edit an existing Topic or add a new one: Undefined subroutine &Foswiki::Form::Select::TAINT called

It refers to /lib/Foswiki/Forms/Select.pm, Changing line $str = TAINT($1); to $str = $1; "fixed" the Problem.

Any Idea whats wrong? Other Webs, other Forms, even other Forms in the same Web work well.

Example Link for creating a topic: http://wiki.example.com/foswiki/bin/edit/Media/BibliothekBestandAUTOINC0001?topicparent=Bibliothek;templatetopic=BibliothekBestandTemplate;formtemplate=Media.BibliothekForm;action=form

-- ChristianSchmidt

setting to urgent until we know that its not a Foswiki issue, or until we give up waiting for details.

Christian, as the URL isn't a real one, can you give us the form definition too?

-- SvenDowideit - 08 Feb 2009

TAINT is defined in Assert.pm, and this module must be imported for a TAINT call to work. It isn't imorted in this case, which strongly suggests that this code is not exercised during unit tests. The code should be exercised by a select+values.

Confirmed and fixed.

-- CrawfordCurrie - 08 Feb 2009

ItemTemplate edit

Summary Undefined subroutine &Foswiki::Form::Select::TAINT called
ReportedBy ChristianSchmidt
Codebase 1.0.0
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Engine
Component
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:bd889eaf64a4
TargetRelease patch
ReleasedIn 1.0.1
Topic revision: r6 - 23 Feb 2009, KennethLavrsen - This page was cached on 21 Jun 2018 - 18:04.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy