You are here: Foswiki>Tasks Web>Item9601 (05 Jul 2015, GeorgeClark)Edit Attach

Item9601: CommentPlugin forces uprev each time you save

Priority: Normal
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Extension
Component: CommentPlugin
Reported By: KennethLavrsen
Waiting For:
Last Change By: GeorgeClark
CommentPlugin has gone through a total rewrite and feature creap while I was in US.

And the result is as you can expect bugs. And this first one is an absolute show stopper.

Each time you add a comment to a page now it gets upreved. Even when the same person adds many comments.

We use CommentPlugin many places in meeting minutes, in reports, many places.

The CommentPlugin when must behave like any other edit/save cycle. First time a user saves a topic it is upreved. Within the 1 hour period additional saves does not uprev unless the user clicks the force uprev checkmark.

In our applications we will experience that topics are uprev'ed 20-50 times in an hour unless this stupid new behavior is fixed. It is not acceptable.

This change should not have happened without a feature proposal and the total rewrite of a core plugin just before a beta release is totally unacceptable. Why did you do it? How many more bugs will we have to fix the next weeks? Please revert this whole checkin - or I will.

This should have been deferred to 1.2

-- KennethLavrsen - 01 Sep 2010

I checked in because I have to bugfix and release plugins I maintain. The release should have been branched by now; freezing the trunk for such a long period is crippling progress. Not saying I did the right thing, just saying why. I reverted the change, and will re-apply it when the 1.1 branch is finally created.

-- CrawfordCurrie - 01 Sep 2010

As it is rejected for 1.1.0, this will have to wait for 1.1.1

Topic revision: r8 - 05 Jul 2015, GeorgeClark - This page was cached on 04 Oct 2015 - 17:12. Get a fresh version here.
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License