Item9446: Put-it-back action does not restore topic references

Priority: Urgent
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component: Rename
Branches:
Reported By: GeorgeClark
Waiting For:
Last Change By: KennethLavrsen
When a topic is renamed, the confirmation dialog lists the topics to be changed, and the POST to complete the rename includes the list of referring topics:

validation_key=215dad94317986aa75c65366d99a084c&newweb=Sandbox&newtopic=TestBlahTemplate&newattachment=&referring_topics=Sandbox.TestTopic0&referring_topics=Sandbox.TestTopic1

However the "put-it-back" action does not include the referring_topics in the post, so references are not updated.

validation_key=fccaeb117a6679165f4293646f5e52bc&newweb=Sandbox&newtopic=TestTabbedTemplate&nonwikiword=checked&newattachment=TestTabbedTemplate&nonwikiword=checked&nonwikiword=checked

This seems to be a template issue - the LOCAL_SEARCH and GLOBAL_SEARCH macros are created by the rename request, but are not shown or passed through renameconfirm.tmpl

-- GeorgeClark - 10 Aug 2010

We do not have a put-it-back feature in PatternSkin any longer (and I will not miss it) so where do you see this?

The plain renaming works so I am not sure how to reproduce this.

-- KennethLavrsen - 18 Aug 2010

OK. With the help from IRC I see it now. It was a bug in 1.0.9 that the META was not saved when moving.

The shit message is still in PatternSkin.

And if we have such a feature it should work. If you move something the backlinks should be updated. And the feature must work like normal rename so you can unselect where the suggested backlinks are not correct.

-- KennethLavrsen - 18 Aug 2010

from IRC

[08:57] <Lavr> Maybe we could get Arthur to move the Topic Moved message into the More Topic Actions field. If this message was just above the normal rename feature clicking the put it back would just be a normal rename action.
[08:58] <CDot> Lavr: now *that's* an excellent idea
[08:58] <MTempest> Lavr++

We are many that hate the intrusive message about the topic having been moved in plain sight at the bottom of normal view.

My proposal is to remove it from PatternSkin's normal view template and add the feature to the More Topic Actions screen.

In the More Actions we have already the

Rename or move topic

* Rename/move topic... scans links in all public webs (recommended) * Rename/move topic... scans links in Sandbox web only

In case we have a META:TOPICMOVED I would add 1 extra line.

Rename or move topic

* Rename/move topic... scans links in all public webs (recommended) * Rename/move topic... scans links in Sandbox web only * Topic moved from TestTopic1 on 18 Aug 2010 - 06:41 by KennethLavrsen - put it back

When you click the put it back, you should get a normal rename where the only difference is that the new topic name is already populated.

This way we have ONE rename feature to maintain.

We can consider having two new lines. One with "scans links in all public webs" and one with "scans links in Sandbox web only"

Or have a checkmark instead of the many links.

ArthurClemens - this sounds like one of those you are dammed good at making right the first time.

It would cure a bug, remove something that has been raised as an issue before, and the release manager would say the bugfix overweighs the small smell of feature creep.

If you do not have time, remove your name from Waiting For Arthur.

-- KennethLavrsen - 18 Aug 2010

I would love to fix this. ETC end of this week?

-- ArthurClemens - 18 Aug 2010

Thanks Arthur. Changing the state to Being Worked On.

-- KennethLavrsen - 19 Aug 2010

I have moved the message to the more screen. To do:
  • unify the rename pages to 1 template

-- ArthurClemens - 19 Aug 2010

I have also unified all forms on the more page.

-- ArthurClemens - 22 Aug 2010

Re-opening as one small mistake make it fail the HTML Validation tests.

-- OlivierRaginel - 23 Aug 2010

 
Topic revision: r19 - 04 Oct 2010, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License