New Foswiki release 2.1.6 is available with important security fixes.
Sourceforge foswiki email lists being discontinued. Subscribe to the new Foswiki announce and discuss lists at MailingLists

Item9237: Configure save results should appear on main configure dialog

Priority: Normal
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component: Configure
Reported By: GeorgeClark
Waiting For:
Last Change By: KennethLavrsen
SvenDowideit commented that the "initial configuration" performed when LocalSite.cfg is missing sets a number of defaults beyond the 8 or 10 file paths that are guessed on the first pass. The save results dialog doesn't give the user clear guidance to return to bin/configure so that the checkers can make an additional pass of the configuration. Also the "Introduction" panel also presents the same link to the homepage, as well as other useful instructions for the new user. So the extra save results dialog doesn't really add that much value.

Sven also raised points that many of the other default settings may not be appropriate for a secure site. It's nowhere made clear that there are other defaults that really need to be carefully reviewed before going live.

I've got fixes I can check in that eliminates the separate feedback page and passes the feedback to the top of the Welcome/Introduction panel, pushing down the instructions and legend.

Another possible enhancement to address this would be adding a "review sensitive settings" warning that flags other settings as needing review.

-- GeorgeClark - 02 Jul 2010

I would love foswiki 1.1's configure to remove the after save dialog, and instead put the 'I saved:' information into the Introduction tab (or a new one..)

that i think is a really good improvement irrespective of my other worries.

review sensitive settings isa 1.2 feature idea i think.

That some guessed settings are not reported, imo we should raise as a seperate task, so we can hunt them down and re-do that code to make them reported.

the rest of my issue, I think i need to think and discuss more, and probably is too late in the 1.1 dev cycle.

and importantly, thankyou - without your work, i probably would have ignored it again, as i have too many releases in a row :/

-- SvenDowideit - 02 Jul 2010

I've committed the changes to configure save flow. The formatting really needs some help. It seems to work correctly for new password and password change, initial configuration with invalid LocalSite.cfg, and ongoing configuration. But I expect I've missed things. I don't like the results showing after the "Introduction" heading but have not figured out that yet. Might be easier to come up with a better name for the tab.

-- GeorgeClark - 02 Jul 2010

The showing of the results is much better now, but why is the button at the bottom marked "Save Changes"? When I click it, it tells me I've nothing to save, so it's not the end of the world, but it does break the flow and add a source of confusion.

-- CrawfordCurrie - 08 Jul 2010

The first page has always said "Save Changes" in the bottom button whether or not any fields have been changed. I went back to an April build and it's the same way. I'm not sure how to accomplish this other than possibly some Javascript that changes the button state when a field is changed. However considering Sven's comments on fields also being changed by the checkers after the initial save, it would have to be more than just .js.

-- GeorgeClark - 08 Jul 2010

I like the utility, but it'd be great if we can get some help improving the UI look. smile - adding Arthur

-- SvenDowideit - 13 Jul 2010

Early this year we have tried to make the "Save changes" button smarter, but it was not that easy. In the end I have reverted to current behaviour so at least there are no bugs.

I like the changes feedback on the front page, but I think it should be above the main interface, possibly above the security warning.

-- ArthurClemens - 14 Aug 2010

Suggestions on how to move the results up to the top - but only show on "Introduction" tab would be helpful. IIRC I tried and couldn't figure how to push them up higher.

-- GeorgeClark - 15 Aug 2010

Change to Waiting for release.

-- GeorgeClark - 21 Aug 2010

Moved the messages to the top of the page.

-- ArthurClemens - 22 Aug 2010

Now that I've seen the results at the top - esp. when there are a lot of changes, like after the initial config, it's MUCH better on the Intro. The last changes remain in the way otherwise, and make things more difficult to use - scrolling down to find the config panel. On a small screen the config tabs, panels would be pushed off the bottom of the page.

IMHO, this should be reverted.

-- GeorgeClark - 22 Aug 2010

The changes do not remain in the way because you can hide the message after reading. Putting them in the intro text does not fit logically. It is not an introduction message after all.

-- ArthurClemens - 22 Aug 2010

Okay - I finally noticed the little [hide] link - I looked at that panel a half dozen times, resized browser window to several other sizes to confirm that it messes up the users view of configure. Maybe this needs to be bigger - or a button.

-- GeorgeClark - 22 Aug 2010

"messes up the users view of configure" - perhaps you can be a bit more specific.

I think a close button is a good idea.

-- ArthurClemens - 22 Aug 2010

Just that on a smaller browser window, the expected configure panels are below the bottom of the browser, so the user is presented with a block of updates, and has to scroll down to find what to do next. The first time the user will encounter this is after the first update in a new install. But an acknowledge updates button will resolve that concern. (Would be nice to be able to un-hide btw).

-- GeorgeClark - 22 Aug 2010

Changed to waiting for release. The current implementation looks okay.

-- GeorgeClark - 13 Sep 2010

ItemTemplate edit

Summary Configure save results should appear on main configure dialog
ReportedBy GeorgeClark
Codebase trunk
SVN Range
AppliesTo Engine
Component Configure
Priority Normal
CurrentState Closed
Checkins distro:c4f3b7f5402b distro:a44071d208ef distro:260876231d79
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r21 - 04 Oct 2010, KennethLavrsen - This page was cached on 20 Sep 2018 - 10:49.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy