Item9207: Attach.pm not including image size for some JPEG files

Priority: Normal
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component: TopicAttachment
Reported By: TimotheLitt
Waiting For:
Last Change By: GeorgeClark
When creating a link for a new attachment, Attach.pm parses image files to determine the image size for the ≶IMG> tag.

The magic code for JPEG files doesn't handle jpeg DCF - the format used by digital camera media cards. So many, many of today's attached JPEG files don't get the intended height and width in the tag!

This goes back to, and still exists in, TWiki

Easy fix:

in
sub _imgsize {
Replace:
            elsif ($a == 0xFF
                && $b == 0xD8
                && $c == 0xFF
                && $d == 0xE0 )
            {

                #  JPG ff d8 ff e0
With:
            elsif ($a == 0xFF
                && $b == 0xD8
                && $c == 0xFF
                && ($d == 0xE0 || $d == 0xE1) )
            {

                #  JPG ff d8 ff e0/e1=

-- TimotheLitt - 27 Jun 2010

Thanks for the fix. Checked into trunk

-- KennethLavrsen - 27 Jun 2010
 

ItemTemplate edit

Summary Attach.pm not including image size for some JPEG files
ReportedBy TimotheLitt
Codebase trunk
SVN Range
AppliesTo Engine
Component TopicAttachment
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:f1130a15f038
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r5 - 15 Mar 2011, GeorgeClark
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License