Item9175: Bracketed links with question marks are not rendered

pencil
Priority: Normal
Current State: Closed
Released In: 1.0.10
Target Release: patch
Applies To: Engine
Component:
Branches:
Reported By: AndrewJones
Waiting For: Main.AndrewJones
Last Change By: KennethLavrsen
Only applies to 1.0.9, already fixed in trunk.

Not sure if there will be a 1.0.10, but committed the fix anyway.

-- AndrewJones - 18 Jun 2010

This seems to be incomplete. Your change removes the ?params, but doesn't pass them back up the chain to be rendered. _renderWikiWord, renderExistingWikiWord, and internalLink all need changes to pass along the params. I've ported over the unit tests for Anchors and Params into the branch. I'll hold off on committing them.

-- GeorgeClark - 18 Jun 2010

Yeah sorry, I have checked in the rest of the fix.

Could you please check in the unit tests? If they don't pass then I will look into them.

-- AndrewJones - 19 Jun 2010

Unit Tests checked in - they run fine here.

 

ItemTemplate edit

Summary Bracketed links with question marks are not rendered
ReportedBy AndrewJones
Codebase 1.0.9
SVN Range
AppliesTo Engine
Component
Priority Normal
CurrentState Closed
WaitingFor AndrewJones
Checkins distro:a2997c729a08 distro:a9581fb5e00f distro:7e0e5181e1d3
TargetRelease patch
ReleasedIn 1.0.10
Topic revision: r11 - 08 Sep 2010, KennethLavrsen
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy