Item9070: Single quotes in INCLUDE causes crash

Priority:	CurrentState:	AppliesTo:	Component:	WaitingFor:
Urgent	Closed	Engine

[Thu May 27 01:42:39 2010] [error] [client 124.171.138.250] ----what the (/usr/home/trunk.foswiki.org/core/data/Tasks/'Tasks.MyItems'
[Thu May 27 01:42:39 2010] [error] [client 124.171.138.250]     section='tableformat'
[Thu May 27 01:42:39 2010] [error] [client 124.171.138.250]     Web='Tasks'
[Thu May 27 01:42:39 2010] [error] [client 124.171.138.250]     Topic='Item9062'
[Thu May 27 01:42:39 2010] [error] [client 124.171.138.250]     AppliesTo='Engine'
[Thu May 27 01:42:39 2010] [error] [client 124.171.138.250]     Component=''
[Thu May 27 01:42:39 2010] [error] [client 124.171.138.250]     Checkins='Foswikirev:7547 Foswikirev:7551'
[Thu May 27 01:42:39 2010] [error] [client 124.171.138.250]     Summary='shipped core plugins need to be enabled in the Foswiki.spec'
[Thu May 27 01:42:39 2010] [error] [client 124.171.138.250]     CurrentState=''
[Thu May 27 01:42:39 2010] [error] [client 124.171.138.250]     Date='26 May 2010 - 01:46'
[Thu May 27 01:42:39 2010] [error] [client 124.171.138.250]     By='SvenDowideit'.txt)
[Thu May 27 01:42:40 2010] [error] [client 124.171.138.250] File does not exist: /home/trunk.foswiki.org/core/favicon.ico

the bit between the () is what is passed to handler->storedDataExists() which should never happen.

-- SvenDowideit - 27 May 2010

Where were the single quotes?

-- CrawfordCurrie - 27 May 2010

used for every parameter of the INLCUDE

ie

%INCLUDE{'Tasks.MyItems'
section='tableformat'
Web='Tasks'
Topic='Item9062'
AppliesTo='Engine'
Component=''
Checkins='Foswikirev:7547 Foswikirev:7551'
Summary='shipped core plugins need to be enabled in the Foswiki.spec'
CurrentState=''
Date='26 May 2010 - 01:46'
By='SvenDowideit'
}%

What surprised me most is that it gets so far into the internals.

-- SvenDowideit - 28 May 2010

added unit test, which showed me we're not making sure what we toss at the Store isa filtered TopicName.

-- SvenDowideit - 18 Jun 2010