Item8883: trunk default skin, and thus WidgetsSkin is missing validation_keys in things like the upload UI

Which interestingly makes the extension uploader fail.

default skin should have this right

-- SvenDowideit - 10 Apr 2010

Are you sure? If by "upload UI" you mean /bin/attach, I see no problem with default skin from my end.

The hidden <input valudation_key...> fields are added late in rendering by a regex matching <form> tags in Foswiki::writeCompletePage()

-- PaulHarvey - 21 Apr 2010

ok, the details:

I have a private tmplatepwd passworded extensions repository (ok, one per cleint), running WidgetsSkin, and whenever I do a -build.pl upload= it gives me a

WARNING: The form does not have a validation_key field

so something's not perfect - I expect it to not need changes to the widgets skin, but i really dunno.

-- SvenDowideit - 09 Jul 2010

That sounds like a skin problem in widgets skin to me..... without significantly more detail, I can't even begin to guess, nor anyone else who can't reproduce it. I feel it's unlikely to be a valid release blocker for 1.1, though, so assigning to WidgetsSkin and leaving for Sven's feedback.

-- CrawfordCurrie - 28 Jul 2010

It could also be a validation issue. If the <form> markup isn't valid, the client may not be POSTing the validation key back properly

-- PaulHarvey - 29 Jul 2010

thing is, WidgetsSkin does not define this stuff - its using the default skin... (WidgetsSkin is a thin layer)

-- SvenDowideit - 08 Oct 2011

Commenting is disabled while not logged in