You are here: Foswiki>Tasks Web>Item8668 (02 Dec 2012, GeorgeClark)Edit Attach

Item8668: Log changes shouldn't require user to edit LocalSite.cfg

pencil
Priority: Normal
Current State: Closed
Released In: 1.1.6
Target Release: patch
Applies To: Engine
Component: Configure
Branches: Release01x01 trunk
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
The new log changes in bin/configure present the user with a large number of warning messages that seem to expect the user to manually edit LocalSite.cfg to remove deprecated parameters. configure should remove the deprecated parameters.

Warning: Deprecated $Foswiki::cfg{Log}{search} setting should be removed from lib/LocalSite.cfg
Warning: Deprecated $Foswiki::cfg{Log}{rest} setting should be removed from lib/LocalSite.cfg
Warning: Deprecated $Foswiki::cfg{Log}{edit} setting should be removed from lib/LocalSite.cfg
Warning: Deprecated $Foswiki::cfg{Log}{register} setting should be removed from lib/LocalSite.cfg
Warning: Deprecated $Foswiki::cfg{Log}{save} setting should be removed from lib/LocalSite.cfg
Warning: Deprecated $Foswiki::cfg{Log}{rename} setting should be removed from lib/LocalSite.cfg
Warning: Deprecated $Foswiki::cfg{Log}{changes} setting should be removed from lib/LocalSite.cfg
Warning: Deprecated $Foswiki::cfg{Log}{view} setting should be removed from lib/LocalSite.cfg
Warning: Deprecated $Foswiki::cfg{Log}{rdiff} setting should be removed from lib/LocalSite.cfg
Warning: Deprecated $Foswiki::cfg{Log}{upload} setting should be removed from lib/LocalSite.cfg
Warning: Deprecated $Foswiki::cfg{Log}{attach} setting should be removed from lib/LocalSite.cfg

Also I'm not sure I understand the following message:

{Log}{Implementation}   Foswiki::Logger::PlainFile
Warning: Found a setting for LogFileName in LocalSite.cfg, so I have automatically selected the Compatibility logger. 

If it's selected the Compatibility logger, shouldn't the selection box show Foswiki::Logger::Commpatibity

-- GeorgeClark - 05 Mar 2010

It's all to do with compatibility. The LogFileName parameter was removed, but if it's still used, then the compatibility logger gets selected on the principle of least surprise.

Same holds with the deprecated parameters. Don;t remove anything the user thought they had set.

-- CrawfordCurrie - 18 Jan 2012

I understand the compatibility issue. My comment about why had to do with why the selection box isn't (or wasn't) updated. At the time it still shows PlainFile when using Compatibility.

As far as removing parameters. For some, manually editing LocalSite.cfg is both difficult and dangerous. Do all hosted sites allow shell access? My objection was making some poor soul edit a rather arcane (to the non perl-programmer) file. Maybe configure needs a checkbox that allows the user to save a config with the removed parameters.

In any event, this is becoming less of a problem as sites migrate to 1.1. Though from recent IRC discussions suggest that there are quite a few 1.0 sites out there. This also begs the point that we don't officially support migration of a config from 1.0 to 1.1. In addition to the logger, migrating from 1.0 to 1.1 breaks the QUERY parser by omitting the OP_match definition.

-- GeorgeClark - 19 Jan 2012

Config migration is always a tough call, but we should probably take a tougher line on it and simply upgrade the config without asking too many questions; experience suggests that most people prefer that to being left with too many choices. esp. when those choices are invisible. We should aim to support migration of a config through configure i.e. version x+1 should read a version x compatible config, but need not write one.

-- CrawfordCurrie - 30 Jan 2012

It might be better to use the conditional config display feature to add back in and allow configuration of these parameters. Because of the log rotation overhead, there are some sites where Compatibility logger will be greatly preferred ... avoids the 12:01am crash on the first of the month.

-- GeorgeClark - 14 Oct 2012

The configuration for Compatibility logger has been restored to Foswiki.spec. Manual edit is still needed to remove the older {Log}{<script>} settings.

-- GeorgeClark - 17 Oct 2012
 

ItemTemplate edit

Summary Log changes shouldn't require user to edit LocalSite.cfg
ReportedBy GeorgeClark
Codebase
SVN Range
AppliesTo Engine
Component Configure
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:d9ee6f9148fa distro:ee638814297c
TargetRelease patch
ReleasedIn 1.1.6
CheckinsOnBranches Release01x01 trunk
trunkCheckins distro:d9ee6f9148fa
Release01x01Checkins distro:ee638814297c
Topic revision: r8 - 02 Dec 2012, GeorgeClark - This page was cached on 04 Dec 2016 - 23:27.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License