You are here: Foswiki>Tasks Web>Item8656 (12 Dec 2017, GeorgeClark)Edit Attach

Item8656: Disable edit button of EDITTABLE if user is not allowed to edit page

Priority: Enhancement
Current State: Needs Developer
Released In:
Target Release: n/a
Applies To: Extension
Component: EditTablePlugin
Reported By: TobiasVonDerKrone
Waiting For:
Last Change By: GeorgeClark

it would be nice if using the EDITTABLE from the EditTablePlugin and the user is not allowed to edit/change the topic, the edit button is disabled/greyed out.

-- TobiasVonDerKrone - 03 Mar 2010

This is under investigation for the next major release of Foswiki. See AddStaticContext for some of the discussions There are two slightly different situations:
  • Conventional rendering of the page for a user without change access.
  • Static rendering of a page, such as for PDF output where edit would not be possible.

-- GeorgeClark - 03 Mar 2010

Thank you for the hint. This would solve the issue.

-- TobiasVonDerKrone - 03 Mar 2010

I am not 100% in favour of this

If I am at a site where I can view without authentication, I enjoy being able to click Edit and then be authenticated. Otherwise you always have to authenticate via a login link first.

If I am already authenticated, and have no access, it would make more sense to hide or grey out the edit button.

I can also question if the end user intuitively will know that he could have had edit access rights if he asks for it. If you cannot see the edit button how will you know that you can edit if you ask the topic owner to give you access. If I click on an edit button and get a buh! screen then I know.

User interaction is not always that simple. There are advantages and disadvantages of both approaches.

I wonder what people like Arthur and Carlo thinks about this.

I often need to disable the Edit Table Plugin if topic is included in another topic. So maybe we need a generic feature where we can define criteria for enabling the plugin. Two criteria come to mind: "access rights and include status".

If done this should go via a feature proposal because this plugin is a default distribution plugin that follows the release process.

-- KennethLavrsen - 03 Mar 2010

These 2 scenarios:
  1. Not logged in: Foswiki knows nothing of you: show edit button.
  2. Logged in:
    1. Have rights: as is
    2. Have no rights: instead of button show message "you don't have writing rights to edit this table" (please improve copy)

-- ArthurClemens - 03 Mar 2010

ItemTemplate edit

Summary Disable edit button of EDITTABLE if user is not allowed to edit page
ReportedBy TobiasVonDerKrone
Codebase 1.0.9
SVN Range
AppliesTo Extension
Component EditTablePlugin
Priority Enhancement
CurrentState Needs Developer
TargetRelease n/a
Topic revision: r7 - 12 Dec 2017, GeorgeClark - This page was cached on 07 Jun 2020 - 03:44.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy