NOTE: If you are a developer, please use a private wiki based on foswiki/trunk on a daily base ...or use trunk.foswiki.org to view this page for some minimal testing.
Use Item9693 for docu changes for 1.2 and 2.0.
You are here: Foswiki>Tasks Web>Item8611 (04 Oct 2010, KennethLavrsen) Edit this topic text (e) Attach an image or document to this topic; manage existing attachments (a) View sequential topic history View without formatting (v) Create new topic Printable version of this topic (p) More: delete or rename this topic; set parent topic; view and compare revisions (m)

Item8611: A COMMENT gets applied again when a save is invoked from an afterSaveHandler

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Urgent Closed Engine CommentPlugin  
COMMENT uses the beforeSaveHandler to re-read the topic and insert the comment. It gets the comment from the URL params. But if we have the scenario where another plugin has an afterSaveHandler which saves a different topic, then the beforeSaveHandler in the CommentPlugin will end up inserting the comment again.

The workaround is for the calling plugin to ensure that any URL params are removed from the request before saving any further topics. The fix is for CommentPlugin to remove those same params after it has processed them once.

-- CrawfordCurrie - 24 Feb 2010

 

ItemTemplate edit

Summary A COMMENT gets applied again when a save is invoked from an afterSaveHandler
ReportedBy CrawfordCurrie
Codebase
SVN Range
AppliesTo Engine
Component CommentPlugin
Priority Urgent
CurrentState Closed
WaitingFor
Checkins Foswikirev:6512
TargetRelease minor
ReleasedIn 1.1.0
Edit | Attach | Print version | History: r4 < r3 < r2 < r1 | Backlinks | View wiki text | Edit wiki text | More topic actions
Topic revision: r4 - 04 Oct 2010, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons LicenseGet Foswiki at sourceforge.net. Fast, secure and Free Open Source software downloads