The foswiki svn repository will become read-only on Friday 8/8. Developers should register for a http://github.com/ account for commit access to foswiki.

Item8477: Strikeone should warn users if they have have js turned off

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Urgent Closed Engine    
I installed noscript on my netbook, and suddenly, I was losing every edit I made on foswiki.org and trunk.foswiki.org

  1. edit topic (you get raw edit)
  2. hit save
  3. see 'Warning! Confirmation required' dialog
  4. hit 'OK', as it says '# Press OK to confirm that this change was intentional.'
  5. goes to view topic and no save has occurred.

I'm not thrilled that our protection breaks legitimate usage with js off

but a much bigger issue is that there is nothing telling the innocent user that they are about to lose their work, or why.

-- SvenDowideit - 07 Feb 2010

This is a very real issue, but I'm somewhat at a loss to know what to do about it. Suggestions are welcome, code even more welcome.

-- CrawfordCurrie - 11 Mar 2010

Since strikeone may not be enabled .

Best would be to disable edit when JS is not enabled AND strikeone is enabled. This means telling the JS if strikeone is enabled. I am no JS expert but I assume it is possible but a bit messy.

I personally consider this less urgent. I think very few users run with JS off these days because nothing on the internet works without anymore.

-- KennethLavrsen - 11 Mar 2010

How does the server know JS is disabled? How does it know it has been disabled by the user, rather than it's been disabled because someone is trying a cross-posting hack? There is no automatic, safe solution to this without fatally weakening the protection that strikeone offers. The only option is to add a message to the confirmation dialog that says something like:

"If JS is off, then go back in the browser and turn it on before trying to save again" if strikeone is enabled.

After some experimentation, I can make the message rewrite using onload JS. Not sure how reliable it will be, but worth a try.

-- CrawfordCurrie - 24 Mar 2010

 

ItemTemplate edit

Summary Strikeone should warn users if they have have js turned off
ReportedBy SvenDowideit
Codebase 1.0.9
SVN Range
AppliesTo Engine
Component
Priority Urgent
CurrentState Closed
WaitingFor
Checkins Foswikirev:6886 Foswikirev:6887 Foswikirev:6889 Foswikirev:6895 Foswikirev:6902
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r20 - 04 Oct 2010, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License