New Foswiki release 2.1.6 is available with important security fixes.
Sourceforge foswiki email lists being discontinued. Subscribe to the new Foswiki announce and discuss lists at MailingLists

Item5853: PurePerl taint error inspired fix.

Priority: Normal
Current State: Closed
Released In: 1.0.1
Target Release: patch
Applies To: Engine
Reported By: TWiki:Main.SvenDowideit
Waiting For:
Last Change By: KennethLavrsen
Mark Aufflick found a taint issue in Pure Perl search, and fixed it using a much nicer bit of code that we have.

to prevent jealousy, I'm going to steal his code. So ner.

(I've emailed with him, and it seems he's using an ancient Perl 5.8.0, but nonetheless, removing an eval if we can is good.)

-- TWiki:Main/SvenDowideit - 31 Jul 2008

mmm, looks like it breaks the unit tests as is - so not a quick fix yet

-- TWiki:Main.SvenDowideit - 31 Jul 2008

There's no indication of what the issue is, or what the patrch is, so impossible for anyone but Sven to work on this. Set waiting for his fb

-- CrawfordCurrie - 04 Jan 2009

ah, mark's site had lost its mind, its back now -

-- SvenDowideit - 05 Feb 2009

Code changed

-- CrawfordCurrie - 05 Feb 2009

Code changed without engaging brain it breaks SEARCH unit tests - I've backed it out again pending analysis

-- SvenDowideit - 06 Feb 2009

m//o suggests it never worked for more than a single search in a single request.

Fixed and recommitted. And this time I actually read the test results.

-- CrawfordCurrie - 06 Feb 2009

ItemTemplate edit

Summary PurePerl taint error inspired fix.
ReportedBy TWiki:Main.SvenDowideit
SVN Range TWiki-5.0.0, Sun, 27 Jul 2008, build 17148
AppliesTo Engine
Priority Normal
CurrentState Closed
Checkins distro:c864fed509e0 distro:1c43441e0814 distro:0eb59be019d4
TargetRelease patch
ReleasedIn 1.0.1
Topic revision: r11 - 23 Feb 2009, KennethLavrsen - This page was cached on 22 Mar 2018 - 23:13.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License