Foswiki on GitHub is open for business! Next release meeting: Monday Dec. 1, 1300Z

Item5841: Move topic changes non-wiki links

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Normal Closed Engine    

"Move topic" action changes non-wiki links to <oldWeb>.<WikiWordButNoLink> word, for example:

Example page entry: <exclamationPoint>WikiWordButNoWikiLink after move this page to another web, the context changes to: <exclamationPoint><oldWeb>.WikiWordButNoTWikiLink

This text- modification doesn't make sense, move shouldn't change non-twiki links.

-- Main/SaschaVetter - 29 Jul 2008

Short example:

Raw view:

in twiki:

move topic to sandbox changes twiki words:

new raw view:

-- TWiki:Main.SaschaVetter - 07 Aug 2008

There seems to be a really simple fix to this - that is probably very widely impacting.

Render.pm getReferenceRE uses \b to match the beginning / ending of a WikiWord. However punctuation like > from nop, and !, are considered word boundary so escaped WikiWords are incorrectly matched.

Render.pm - everywhere else uses a precompiled regex $STARTWW and $ENDWW to match the beginning or end of a WikiWord. Bringing getReferenceRE to be consistent with all of the other WikiWord matches in Render.PM seems to solve this issue. But not sure what else it breaks.

I guess if it was easy, it would have been fixed. This breaks lots of stuff.

-- GeorgeClark - 01 Aug 2010

ItemTemplate edit

Summary Move topic changes non-wiki links
ReportedBy TWiki:Main.SaschaVetter MichaelDeckert
Codebase
SVN Range TWiki-5.0.0, Sun, 27 Jul 2008, build 17148
AppliesTo Engine
Component
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:707ad4c79ade distro:6f2adfef7a5a
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r11 - 04 Oct 2010, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License