Foswiki on GitHub is open for business! Next release meeting: Monday October 13, 1300Z
Configure does not compare octal settings correctly and it presents the default value as decimal

Look at configure.

Find the settings for {RCS}{dirPermission} and {RCS}{filePermission}

There are two problems - maybe with same root cause.

Even if you never changed them there is always the small red delta and when you hold the mouse of it the default present is 493 and 420 (the first number is 509 in 4.1.0 because of a bug which has been fixed on SVN).

The formfield value is correctly 0755 and 0644.

493 and 420 are decimal values for 0755 and 0644 octal.

I have studied the code and tried to fix it.

The place I get stuck is in lib/TWiki/Configure/Value.pm in subroutine needsSaving. The function $this->getType()->equals($curval, $defval); is always returning false when it is an octal. I do not understand what this object code is trying to do. This is too advanced for me. And obviously too advanced for the one that wrote it because it does not work. wink (meant as fun remark)

I have not yet analysed why the presentation is in decimal.

I think Crawford needs to fix this one. I simply do not understand this object oriented design.

-- TWiki:Main/KennethLavrsen - 28 Jan 2007

After Item3529 was fixed half of this bug was fixed too. configure now compares default with actual correctly.

But when default is not equal actual the mouse over tooltip you see when you hoover over the delta symbol is still displayed in decimal.

When you save the data the changed settings are shown. And in case of an octal the value is shown decimal which may confuse a person to think he typed it wrong.
Agreed, but this is the tip of the iceberg w.r.t. presentation in configure. It is functionally correct, so i have to drop this to Low priority. Raise it again if you think that's unfair.

CC

 

ItemTemplate edit

Summary Configure does not present octal settings correctly
ReportedBy TWiki:Main.KennethLavrsen
Codebase
SVN Range TWiki-4.1.0, Mon, 22 Jan 2007, build 12595
AppliesTo Engine
Component Configure
Priority Low
CurrentState Closed
WaitingFor
Checkins distro:49977fb07c06
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r12 - 14 Mar 2011, GeorgeClark
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License