cross
New Foswiki release 2.1.6 is available with important security fixes.
Sourceforge foswiki email lists being discontinued. Subscribe to the new Foswiki announce and discuss lists at MailingLists
You are here: Foswiki>Tasks Web>Item2434 (17 Jan 2010, PaulHarvey)Edit Attach

Item2434: BASE windowtitle

pencil
Priority: Urgent
Current State: Closed
Released In: 1.0.9
Target Release: patch
Applies To: Engine
Component: foswiki.tmpl
Branches:
Reported By: CarlinhosCecconi
Waiting For:
Last Change By: PaulHarvey
entry BASE%WEB% causes error in windowtitle

Line 25 in foswiki.tmpl:
BASE%WEB% changes %BASEWEB%

%TMPL:DEF{"windowtitle"}%<title>%TMPL:P{"titleaction"}% <nop>%BASETOPIC%%TMPL:P{"titlesep"}%BASE%WEB%%TMPL:P{"titlesep"}%<nop>%WIKITOOLNAME%</title>%TMPL:END%

-- CarlinhosCecconi

Ouch. Blame Sven...

Set to Urgent.

-- ArthurClemens - 30 Nov 2009

For people seeing this defect I will attach a corrected template file so you can easily fix this.

In templates replace the foswiki.tmpl file with the attached

http://foswiki.org/pub/Tasks/Item2434/foswiki.tmpl

The bug is in line 25 where %BASE%WEB% must be corrected to %BASEWEB%

-- KennethLavrsen - 30 Nov 2009

Am I missing something here as it looks like the fix isn't quite correct - I think it should be
%TMPL:DEF{"windowtitle"}%<title>%TMPL:P{"titleaction"}% <nop>%BASETOPIC%%TMPL:P{"titlesep"}%%BASEWEB%%TMPL:P{"titlesep"}%<nop>%WIKITOOLNAME%</title>%TMPL:END%
rather than
%TMPL:DEF{"windowtitle"}%<title>%TMPL:P{"titleaction"}% <nop>%BASETOPIC%%TMPL:P{"titlesep"}%BASEWEB%%TMPL:P{"titlesep"}%<nop>%WIKITOOLNAME%</title>%TMPL:END%
as the closing % of the preceding TMPL isn't present - I think the original % in BASEWEB was in the wrong place rather than superfluous.

-- MartinRowe - 30 Nov 2009

Yes. I had not fixed it correctly. I have fixed the fix.

-- KennethLavrsen - 30 Nov 2009

ItemTemplate edit

Summary BASE windowtitle
ReportedBy CarlinhosCecconi
Codebase 1.0.8
SVN Range
AppliesTo Engine
Component foswiki.tmpl
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:a6a1dffa3146
TargetRelease patch
ReleasedIn 1.0.9
Topic attachments
I Attachment Action Size Date Who Comment
foswiki.tmpltmpl foswiki.tmpl manage 6 K 30 Nov 2009 - 20:21 KennethLavrsen Fix for typo bug in 1.0.8 - 2nd fix the fix version
Topic revision: r10 - 17 Jan 2010, PaulHarvey - This page was cached on 03 May 2018 - 06:29.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License