You are here: Foswiki>Tasks Web>Item2380 (21 Aug 2010, GeorgeClark)Edit Attach

Item2380: i think that Func::checkAccessPremission lies if a topic doesn't exist.

pencil
Priority: Normal
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component:
Branches:
Reported By: SvenDowideit
Waiting For:
Last Change By: GeorgeClark
    return Foswiki::Func::checkAccessPermission(
            'CHANGE', $user, '', $groupName, $groupWeb);

when $groupName does not exist as a topic, the Func code creates a Meta object that returns true, even though is should not?

unit test to follow.

-- SvenDowideit - 19 Nov 2009

I'm trying to fix Item9512 - checkAccessPermission should check web permission when topic is undef (or null).

So is this related. If a topic does not exist, should the permissions be based upon the permissions set in WebPreferences? ie. check CHANGE on non-existing topic should return true if the web permits that topic to be changed (and in this case created?)

-- GeorgeClark - 21 Aug 2010

Setting to Closed - discussion on IRC - this is probably correct behavior. Added a unit test verify this operation.

-- GeorgeClark - 21 Aug 2010
 

ItemTemplate edit

Summary i think that Func::checkAccessPremission lies if a topic doesn't exist.
ReportedBy SvenDowideit
Codebase
SVN Range SVN 5580: Foswiki-1.1.0-dev, Thu, 29 Oct 2009, build 5392
AppliesTo Engine
Component
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:ce02a5f5c0cc
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r4 - 21 Aug 2010, GeorgeClark - This page was cached on 16 Sep 2021 - 14:54.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy