Index: extender.pl =================================================================== --- extender.pl (revision 5505) +++ extender.pl (working copy) @@ -161,9 +161,6 @@ # Can't do this until we have setlib.cfg require Foswiki::Configure::Dependency; -$session->finish(); -undef $session; - sub remap { my $file = shift;-- CrawfordCurrie - 13 Nov 2009 its been working for a while, so closing -- SvenDowideit - 18 Jun 2010 The unit tests are definitely using more memory. I noticed that because the FoswikiSuite no longer runs on my dev machine. Devel::Leak::Object shows there are objects that are not being cleaned up. I'm investigating. Foswiki::Request does not have a finish() method. I am unsure of the implications of adding one, because
Foswiki::new()
's $query
parameter is a Foswiki::Request object but Foswiki::new()
creates its own Foswiki::Request if the $query
is false (i.e. undef). Foswiki::finish()
should not "finish" the Foswiki::Request object if it was passed as an input (but it should "finish" the one it creates itself).
-- MichaelTempest - 15 Aug 2010
I am not sure how much of the output from Devel::Leak::Object is noise, and my attempt at cleaning up broke lots of things, so I abandoned that attempt. In consequence, I didn't add a finish() for Foswiki::Request.
However, I did find (and fix) an incorrect name in the StoreSmokeTests. I also found that Foswiki::finish() didn't list all of its fields.
I moved Fn_SEARCH to run its own process and now the unit tests run on my machine.
-- MichaelTempest - 22 Aug 2010 Summary | looking into why the unit test FoswikiSuite uses more memory over time |
ReportedBy | SvenDowideit |
Codebase | 1.0.7, trunk |
SVN Range | Foswiki-1.0.7, Sun, 20 Sep 2009, build 5061 |
AppliesTo | Engine |
Component | |
Priority | Normal |
CurrentState | Closed |
WaitingFor | |
Checkins | distro:cd96d395a35a distro:a685b015572b distro:c2f811edc152 distro:745351d7e9d9 distro:46e29d73ab9a distro:fad35b89ba96 distro:78a54b4c1952 distro:106fd3c58b50 distro:56190d5e4d43 distro:26f8082be135 distro:e04b9b65171e |
TargetRelease | minor |
ReleasedIn | 1.1.0 |