Item2137: configure fails to show many many plugins in Find More Extensions

Priority: Urgent
Current State: Closed
Released In: 1.0.8
Target Release: patch
Applies To: Engine
Reported By: KennethLavrsen
Waiting For:
Last Change By: KennethLavrsen
Some recent change make Configure fail to show quite many extensions in Find More extensions.

It finds 103 and we have something like 200.

It is in the code

                if (defined $page) {
                    $page =~ s/(?:^|\n){(.*?)\n\s*}(\n|$)/
                      $this->_parseRow($1, $place)/ges;

that fails.

In the FastReport

{ topic: AntiWikiSpamPlugin
 description:  lightweight wiki spam prevention
 classification: Security
 version: 1741 (04 Jan 2009) 
{ topic: ApprovalPlugin
 description:  Defines a set of states for one or more topics, with each state requiring approval by one or more users.
 compatibility: Foswiki >=1.0
 classification: Workflow automation
 version: 3923 (2009-05-16) 
 release: 1.0 

the AntiWikiSpamPlugin is parsed but the ApprovalPlugin is not

If I change the code to

$page =~ s/{(.*?)}/$this->_parseRow($1, $place)/ges;

it works again. This is the code from 1.0.6

We need a fix to FastReport to fix this in addition to fixing configure because otherwise I have to release a 1.0.8. It is not enough to just apply my fix.

-- KennethLavrsen - 22 Sep 2009

I tried for the hell of it to add an extra $n to the search format in FastReport. That seems to work.

I have tested in 1.0.4 and in 1.0.7.

That will calm down things for now

-- KennethLavrsen - 22 Sep 2009

Checked in the old version of the code. It works. I do not understand why it was changed, or how that was tested.

Please do not remove the $n from FastReport. We have to live with that from now on.

-- KennethLavrsen - 22 Sep 2009

ItemTemplate edit

Summary configure fails to show many many plugins in Find More Extensions
ReportedBy KennethLavrsen
SVN Range Foswiki-1.0.7, Sun, 20 Sep 2009, build 5061
AppliesTo Engine
Priority Urgent
CurrentState Closed
Checkins distro:46adce3df0e1 distro:70c3f5e27fa8
TargetRelease patch
ReleasedIn 1.0.8
Topic revision: r5 - 29 Nov 2009, KennethLavrsen
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy