Item2130: TablePlugin initsort parameter is not tested before use

Priority: Low
Current State: Closed
Released In: 1.0.8
Target Release: patch
Applies To: Extension
Component: TablePlugin
Reported By: KennethLavrsen
Waiting For: Main.KennethLavrsen
Last Change By: KennethLavrsen
I noticed today that some end user had used a TABLE tag with initsort="off"

This is wrong syntax. But the code tries to do math and writes warnings in the error_log

The code should check the data for validity and ignore non-valid data.

Easy fix

-- KennethLavrsen - 21 Sep 2009

I added a check on trunk to make sure the parameter is defined before it is tested with a regex. The release branch does not need it.

-- MichaelTempest - 22 Sep 2009

ItemTemplate edit

Summary TablePlugin initsort parameter is not tested before use
ReportedBy KennethLavrsen
Codebase 1.0.7, trunk
SVN Range SVN 5077: Foswiki-1.1.0-dev, Thu, 03 Sep 2009, build 4764
AppliesTo Extension
Component TablePlugin
Priority Low
CurrentState Closed
WaitingFor KennethLavrsen
Checkins distro:25984dd2f0d7 distro:3a54a1283ff9 distro:409d3911c423
TargetRelease patch
ReleasedIn 1.0.8
Topic revision: r7 - 29 Nov 2009, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License