Item2094: WebRss contains Foswiki copyright

Priority: Normal
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Reported By: ArthurClemens
Waiting For:
Last Change By: KennethLavrsen
description tag:
The [_1] web of Foswiki. Foswiki is the Free and Open Source Wiki.

This should not mention Foswiki, but WIKITOOLNAME instead.

-- ArthurClemens - 18 Sep 2009

Changing the first occurance of Foswiki to WIKITOOLNAME is easy enough, as in:

%MAKETEXT{"The [_1] web of [_2]. Foswiki is the Free and Open Source Wiki." args="<nop>%WEB%,<nop>%WIKITOOLNAME%"}%

However should we still include the "Foswiki slogan" Or should the web template include the WEBSUMMARY,

%MAKETEXT{"The [_1] web of [_2]. [_3]" args="<nop>%WEB%,<nop>%WIKITOOLNAME%,<nop>%WEBSUMMARY%

We could still keep the slogan available by changing the WEBSUMMARY default for the System web, such as
  • #Set WEBSUMMARY = Discover Foswiki - the Free and Open Source Wiki.
  • #Set WEBSUMMARY = A Test area to experiment hands-on with Foswiki - the Free and Open Source Wiki.

This also reduces the need to tailor the WebRss topic at each site.

-- GeorgeClark - 12 Aug 2010

Note that my change to the WebRss / WebAtom topics breaks the translations for the hard coded title/description of the feed. However using WebPreferences WEBSUMMARY in the feed will make the feeds easier to tailor, and reduce the need to edit the individual WebRss and WebAtom topics.

Note also that if any argument of the MAKETEXT contains a comma, it breaks the macro, interpreting the part after the comma as an additional argument. So I had to move the WEBSUMMARY outside of the MAKETEXT. The final text - which needs adjustments in the translation files is:

RSS Description:  %MAKETEXT{"The [_1] web of [_2]." args="<nop>%WEB%,<nop>%WIKITOOLNAME%"}% <nop>%WEBSUMMARY%
Atom Subtitle:    %MAKETEXT{"The [_1] web of [_2]." args="<nop>%WEB%,<nop>%WIKITOOLNAME%"}% <nop>%WEBSUMMARY%

-- GeorgeClark - 12 Aug 2010

This needed a few more adjustments. As was pointed out on IRC, neither RSS or Atom feeds accept html markup in the description/subtitle field. The fields are now enclosed in <literal> tags to prevent wikiwords or other markup.

Also modified the WebPreferences topics - WEBSUMMARY settings to consistently use MAKETEXT for the default descriptions.

-- GeorgeClark - 13 Aug 2010

ItemTemplate edit

Summary WebRss contains Foswiki copyright
ReportedBy ArthurClemens
Codebase 1.0.9, 1.0.8, 1.0.7, 1.0.6, trunk
SVN Range Foswiki-1.0.6, Sun, 21 Jun 2009, build 4272
AppliesTo Engine
Priority Normal
CurrentState Closed
Checkins distro:be82a476f28e distro:cf650897f7c5 distro:195f3b31bdc4 distro:aae1f6b2e014
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r12 - 04 Oct 2010, KennethLavrsen - This page was cached on 16 Jan 2020 - 11:59.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy