Item1855: Internal Error on any operation when Foswiki::Logger implementation is set to none
Priority: Normal
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component:
Branches:
To test, change the
{Log}{Implementation}
setting to "none" from the configure interface.
The culprit is the method
Foswiki::logger
, which does
eval "require $Foswiki::cfg{Log}{Implementation}"
without checking if the setting is a valid implementation.
I think that there should be a logger implementation that does nothing, and it sould be used when the setting is set to "none". That is way better than to check of undef each time the logger is used.
BTW, the documentation of
Foswiki::logger
has a copy/paste error, it is the same as the
Foswiki::i18n
method.
Flagged as "Urgent" as it prevents the normal operation of Foswiki. Perhaps it can be downgraded to "Normal" as it only affect "Expert" users that change the setting from its default.
--
RafaelAlvarez - 27 Jul 2009
Yeah, Normal. Confirmed and downgraded.
--
CrawfordCurrie - 27 Jul 2009
Fixed on trunk
--
CrawfordCurrie - 27 Jul 2009