Item1682: SEARCH does not work well with format being blank

Priority: Normal
Current State: Closed
Released In: 1.0.6
Target Release: patch
Applies To: Engine
Reported By: KennethLavrsen
Waiting For:
Last Change By: KennethLavrsen
SEARCH with a format works very differently from a SEARCH without.

The current code will see format not defined the same way as format=""

And normally we did not care.

But with the new footer and $nhits and $ntopics feature the use of an empty format suddenly makes a lot of sense.

You can use a construct like format="" footer"$ntopics" separator="" to put the number of topics that matches a search anywhere you want incl inside tables.

I saw today this used where someone put an html <nop> in the format.

It is silly that you end up maybe with 300 nops. Thay may be invisible but they can also create trouble - especially in a nested search.

The fix is to treat format="" exactly as it should be expected. It is a bug that an empty format means no format. An empty format is a format.

It is easy to fix both in trunk and in release branch and I am running the last unit tests as I write this report.

Fix will be in 1.0.6.

-- KennethLavrsen - 03 Jun 2009

ItemTemplate edit

Summary SEARCH does not work well with format being blank
ReportedBy KennethLavrsen
Codebase 1.0.5, trunk
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Engine
Priority Normal
CurrentState Closed
Checkins distro:0c638d7ce628 distro:5bb19c6c4db4
TargetRelease patch
ReleasedIn 1.0.6
Topic revision: r5 - 22 Jun 2009, KennethLavrsen
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy