Foswiki on GitHub is open for business! Next release meeting: Monday Nov. 17, 1300Z

Item1668: The action template in CommentPlugin creates actions on one long line

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Normal Closed Extension CommentPlugin  
The action template in CommentPlugin which is used with ActionTrackerPlugin has two problems

First - it generates one long action and no new line is added each time you add an action making manual editing of the topic difficult.

We can argue if this is a problem in CommentPlugin or ActionTrackerPlugin.

At the moment ActionTrackerPlugin (ATP) will not add or remove any newlines. And this is probably a good idea. Usually trying to add new lines means adding more and more of them each time you edit.

The real root cause is that CommentPlugin never had the action template updated when ATP changed to the new format with an ENDACTION macro. Simply adding this to the action template fixes the issue so this is the clean way to resolve this.

The problem is that newlines become <br /> with the angle brackets encoded. This is due to two things. New lines are defined to be translated into <br /> which then gets encoded.

The ENDACTION feature actually makes the translation of line breaks not needed. So changing to ENDACTION syntax and removing the encoding of line breaks makes the action template work quite nice again.

I will check this into CommentPlugin. I have however a few more updates so I will not release a new version until I have additional fixes checked in.

-- KennethLavrsen - 27 May 2009

ItemTemplate edit

Summary The action template in CommentPlugin creates actions on one long line
ReportedBy KennethLavrsen
Codebase 1.0.5, trunk
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Extension
Component CommentPlugin
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:598e239bd88e distro:4ecf85293ea1
TargetRelease patch
ReleasedIn 1.0.6
Topic revision: r5 - 22 Jun 2009, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License