Foswiki on GitHub is open for business! Next release meeting: Monday Nov. 17, 1300Z

Item1562: redirect failure OK button goes to wrong place

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Normal Closed Engine    
we get it right in the wordage, but then make a mess of the OK button

Access check on Main.WebHome failed. Action "redirect": unsafe redirect to http://t42p/Sandbox/YuiMenu: host does not match {DefaultUrlHost} , and is not in {PermittedRedirectHostUrls}"http://localhost/". 

-- SvenDowideit - 04 May 2009

Can you describe how to reproduce this?

-- CrawfordCurrie - 20 Sep 2009

yup - looking at it now smile use a url (host) different from what is configured as the default / permitted, and save a change - you will get the unsafe redirect message, and the 'OK' points to webhome.

specifically, its because for the unsafe redirect, we're re-using the 'access denied' tmpl - where we should really use something a little smarter (ie, the correct DefaultUrl/resuestedweb/topic..

-- SvenDowideit - 15 Sep 2010

Several issues:
  • Foswiki.pm redirect uses $session->{web} and {topic} when the actual values are webName and topicName
  • As Sven mentions, needs a template with a more relevant [ok] button
  • Rename.pm needs to reset the $session->{webName} and {topicName} to the new web/topic so that if the redirect fails, the ok button has a topic to return to.

-- 13 Mar 2011 - 01:04:47 - GeorgeClark

You forgot to add the new file to the MANIFEST. I have fixed it.

-- KennethLavrsen - 12 Apr 2011

ItemTemplate edit

Summary redirect failure OK button goes to wrong place
ReportedBy SvenDowideit
Codebase 1.0.5, trunk
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Engine
Component
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:4d455b573f12 distro:945e0d6259dd distro:7f55b54fc9e1 distro:3500a127c291
TargetRelease patch
ReleasedIn 1.1.3
Topic revision: r11 - 16 Apr 2011, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License