Item1544: EditTablePlugin no longer disables sort when editing

Priority: Urgent
Current State: Closed
Released In: 1.0.6
Target Release: patch
Applies To: Extension
Component: EditTablePlugin
Branches:
Reported By: KennethLavrsen
Waiting For: Main.KennethLavrsen
Last Change By: KennethLavrsen
Last year we added a feature to both TablePlugin and EditTablePlugin so that when you edit a table, the TablePlugin does not try to initsort the table or show sort links in header.

For some odd reason this feature was wiped out in a recent refactor where other bugs were addressed.

But we cannot live without it.

The editing of an initsorted table is a nightmare. You open a table and see chaos order wise because the TablePlugin gets it all wrong because of the extra columns added for the JS features.

And then you move rows to get it right. And when you save it is all wrong again next time you view.

I have now readded the feature. Please do not remove it again.

-- KennethLavrsen - 29 Apr 2009

If I removed it, it was not intentionally.

-- ArthurClemens - 30 Apr 2009

That is what I expected. It disappeared as part of a larger fix.

BUT SHAME ON ME! I checked in the change without fixing unit test.

As part of my fix I made the decision to always save TABLE and EDITTABLE on TWO lines.

Is this wise?

I think it is. It is easier later to edit the tags and the user probably put them on one line because he thought he had to.

If I am wrong I can revert it again.

But I need to update the unit tests for the two line split.

Note that I am still working on two other fixes so I have not yet released an updated plugin with this fix.

-- KennethLavrsen - 30 Apr 2009

I am fine with saving the 2 tags on 2 lines.

-- ArthurClemens - 30 Apr 2009
Topic revision: r13 - 22 Jun 2009, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License