Item14900: CommentPlugin does not find the comment position if it is at the end of page

pencil
Priority: Normal
Current State: New
Released In: n/a
Target Release:
Applies To: Extension
Component: CommentPlugin
Branches:
Reported By: JanKlusak
Waiting For:
Last Change By: JanKlusak
-- JanKlusak - 15 Apr 2020

If there is a comment macro at the end of a page, its position is not correctly found. This is easily reproducible, if there is a comment macro with type "above" at the end of a page. The next comment is inserted incorrectly below the macro.

This is because one of the serializers removes the trailing endline (no idea if this is correct). When the comment plugin tries to search for the comment position, it expects that the newline is there. As it cannot find the comment (because of missing newline), it goes to fallback, so it inserts the comment at the end of the page.

Attached a patch the fixes the issue.

-- JanKlusak - 15 Apr 2020
 

ItemTemplate edit

Summary CommentPlugin does not find the comment position if it is at the end of page
ReportedBy JanKlusak
Codebase 2.1.6
SVN Range
AppliesTo Extension
Component CommentPlugin
Priority Normal
CurrentState New
WaitingFor
Checkins
ReleasedIn n/a
CheckinsOnBranches
trunkCheckins
masterCheckins
ItemBranchCheckins
Release02x01Checkins
Release02x00Checkins
Release01x01Checkins
Topic attachments
I Attachment Action Size Date Who Comment
Fix_comment_positions.patchpatch Fix_comment_positions.patch manage 638 bytes 15 Apr 2020 - 07:46 JanKlusak  
Topic revision: r1 - 15 Apr 2020, JanKlusak - This page was cached on 06 Aug 2020 - 02:47.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy