Item14760: several files produce warnings on Perl 5.24

pencil
Priority: Enhancement
Current State: New
Released In: n/a
Target Release:
Applies To: Extension
Component: PublishPlugin
Branches: master
Reported By: FlorianSchlichting
Waiting For:
Last Change By: FlorianSchlichting
$ perl -wc -Ilib lib/Foswiki/Plugins/PublishPlugin/Publisher.pm
Variable "$this" will not stay shared at lib/Foswiki/Plugins/PublishPlugin/Publisher.pm line 1051.
lib/Foswiki/Plugins/PublishPlugin/Publisher.pm syntax OK


$ perl -wc -Ilib lib/Foswiki/Plugins/PublishPlugin/BackEnd/flatfile.pm
"my" variable $this masks earlier declaration in same scope at lib/Foswiki/Plugins/PublishPlugin/BackEnd/flatfile.pm line 102.
"my" variable $web masks earlier declaration in same scope at lib/Foswiki/Plugins/PublishPlugin/BackEnd/flatfile.pm line 102.
"my" variable $topic masks earlier declaration in same scope at lib/Foswiki/Plugins/PublishPlugin/BackEnd/flatfile.pm line 102.
"my" variable $attachment masks earlier declaration in same scope at lib/Foswiki/Plugins/PublishPlugin/BackEnd/flatfile.pm line 102.
lib/Foswiki/Plugins/PublishPlugin/BackEnd/flatfile.pm syntax OK


$ perl -wc -Ilib lib/Foswiki/Plugins/PublishPlugin/BackEnd/pdf.pm
...
Use of uninitialized value in concatenation (.) or string at lib/Foswiki/Plugins/PublishPlugin/BackEnd/pdf.pm line 30.
lib/Foswiki/Plugins/PublishPlugin/BackEnd/pdf.pm syntax OK

-- FlorianSchlichting - 18 Sep 2018

The third is bogus, sorry, pseudo-install didn't populate $Foswiki::cfg{Plugins}{PublishPlugin}{PDFCmd} as would usually happen with configure.

For the second, I just pushed a simple fix.

The first is probably due to subs _match() and _matchPart() being inside sub _processURL(); why is that? Wouldn't it be cleaner to move them onto the same level and pass in $this to sub _match() for debug output?

-- FlorianSchlichting - 18 Sep 2018
 
Topic revision: r1 - 18 Sep 2018, FlorianSchlichting - This page was cached on 12 Sep 2020 - 20:46.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy