Item14009: Comment plugin does not properly identify location to insert comment.

There are several problems with the handling of the target parameter by the comment plugin when the target is given as a URL fragment ("#anchor").

1. The anchor is being passed via a hidden form field to the comment plugin's Javascript. This value includes the "#" fragment delimiter, but the Javascript does not take this into account and searches for an anchor tag with a name that includes the delimiter. This fails.
2. For named anchors, Foswiki now generates span tags with an id attribute for the given name. The comment plugin's Javascript does not take this into account.

I'll attach a patch to comment.uncompressed.js that addresses both of these problems.

-- PaulMerchantJr - 07 Mar 2016

Thanks for the fix!

Crawford, could you please review this and I'll get it checked into Foswiki 2.1.1? Thanks.

-- GeorgeClark - 13 Mar 2016

Yes, looks like a good fix. Sorry for taking so long to get to this!

-- Main.CrawfordCurrie - 21 Jan 2017 - 08:59

Commenting is disabled while not logged in